| Message ID | 20240119-aoss-printf-annotation-v1-1-27e2ceb8937a@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b65a3fa38dbb5c84f360a48f0d5da3aed0011964 |
| Headers | show |
| Series | soc: qcom: aoss: Mark qmp_send() __printf() | expand |
On 19.01.2024 18:13, Bjorn Andersson wrote: > As reported by lkp, qmp_send() would benefit from a __printf() marker to > allow the compiler to further validate the passed parameters, fix this. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401100855.UYl3HPPt-lkp@intel.com/ > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Fri, 19 Jan 2024 09:13:37 -0800, Bjorn Andersson wrote: > As reported by lkp, qmp_send() would benefit from a __printf() marker to > allow the compiler to further validate the passed parameters, fix this. > > Applied, thanks! [1/1] soc: qcom: aoss: Mark qmp_send() __printf() commit: b65a3fa38dbb5c84f360a48f0d5da3aed0011964 Best regards,
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index aff0cfb71482..9d7a74767008 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -214,7 +214,7 @@ static bool qmp_message_empty(struct qmp *qmp) * * Return: 0 on success, negative errno on failure */ -int qmp_send(struct qmp *qmp, const char *fmt, ...) +int __printf(2, 3) qmp_send(struct qmp *qmp, const char *fmt, ...) { char buf[QMP_MSG_LEN]; long time_left;
As reported by lkp, qmp_send() would benefit from a __printf() marker to allow the compiler to further validate the passed parameters, fix this. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401100855.UYl3HPPt-lkp@intel.com/ Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- drivers/soc/qcom/qcom_aoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 2863b714f3ad0a9686f2de1b779228ad8c7a8052 change-id: 20240119-aoss-printf-annotation-df3d5bdea253 Best regards,