| Message ID | 20240122114512.55808-2-rsalvaterra@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ALSA: hda: Replace numeric device IDs with constant values | expand |
On 1/22/2024 12:45 PM, Rui Salvaterra wrote: > We have self-explanatory constants for Intel HDA devices, let's use them instead > of magic numbers and code comments. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- > sound/pci/hda/hda_intel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 2276adc84478..66f013ee160d 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1729,8 +1729,8 @@ static int default_bdl_pos_adj(struct azx *chip) > /* some exceptions: Atoms seem problematic with value 1 */ > if (chip->pci->vendor == PCI_VENDOR_ID_INTEL) { > switch (chip->pci->device) { > - case 0x0f04: /* Baytrail */ > - case 0x2284: /* Braswell */ > + case PCI_DEVICE_ID_INTEL_HDA_BYT: > + case PCI_DEVICE_ID_INTEL_HDA_BSW: > return 32; > } > } Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
On Mon, 22 Jan 2024 12:45:12 +0100, Rui Salvaterra wrote: > > We have self-explanatory constants for Intel HDA devices, let's use them instead > of magic numbers and code comments. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> Applied both patches now. Thanks. Takashi
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 2276adc84478..66f013ee160d 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1729,8 +1729,8 @@ static int default_bdl_pos_adj(struct azx *chip) /* some exceptions: Atoms seem problematic with value 1 */ if (chip->pci->vendor == PCI_VENDOR_ID_INTEL) { switch (chip->pci->device) { - case 0x0f04: /* Baytrail */ - case 0x2284: /* Braswell */ + case PCI_DEVICE_ID_INTEL_HDA_BYT: + case PCI_DEVICE_ID_INTEL_HDA_BSW: return 32; } }
We have self-explanatory constants for Intel HDA devices, let's use them instead of magic numbers and code comments. Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- sound/pci/hda/hda_intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)