| Message ID | 20240122114512.55808-3-rsalvaterra@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ALSA: hda: Replace numeric device IDs with constant values | expand |
On 1/22/2024 12:45 PM, Rui Salvaterra wrote: > Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4 > minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ > handling: > > [ 208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated > for card #0. Suggest a bigger bdl_pos_adj. > > Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't > enough to fix the issue here. Default to 64 samples. > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- > sound/pci/hda/hda_intel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 66f013ee160d..1b550c42db09 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip) > case PCI_DEVICE_ID_INTEL_HDA_BYT: > case PCI_DEVICE_ID_INTEL_HDA_BSW: > return 32; > + case PCI_DEVICE_ID_INTEL_HDA_APL: > + return 64; > } > } > Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 66f013ee160d..1b550c42db09 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip) case PCI_DEVICE_ID_INTEL_HDA_BYT: case PCI_DEVICE_ID_INTEL_HDA_BSW: return 32; + case PCI_DEVICE_ID_INTEL_HDA_APL: + return 64; } }
Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4 minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ handling: [ 208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated for card #0. Suggest a bigger bdl_pos_adj. Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't enough to fix the issue here. Default to 64 samples. Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+)