| Message ID | d15dd1d81ffebed4e5028e156f0082c44ebbf2fc.1705935864.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fbcon: Fix incorrect printed function name in fbcon_prepare_logo() | expand |
On 1/22/24 16:04, Geert Uytterhoeven wrote: > If the boot logo does not fit, a message is printed, including a wrong > function name prefix. Instead of correcting the function name (or using > __func__), just use "fbcon", like is done in several other messages. > > While at it, modernize the call by switching to pr_info(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> applied to fbdev git tree. Thanks! Helge > --- > drivers/video/fbdev/core/fbcon.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index 63af6ab034b5f1bb..1183e7a871f8b270 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -631,8 +631,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, > > if (logo_lines > vc->vc_bottom) { > logo_shown = FBCON_LOGO_CANSHOW; > - printk(KERN_INFO > - "fbcon_init: disable boot-logo (boot-logo bigger than screen).\n"); > + pr_info("fbcon: disable boot-logo (boot-logo bigger than screen).\n"); > } else { > logo_shown = FBCON_LOGO_DRAW; > vc->vc_top = logo_lines;
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 63af6ab034b5f1bb..1183e7a871f8b270 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -631,8 +631,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, if (logo_lines > vc->vc_bottom) { logo_shown = FBCON_LOGO_CANSHOW; - printk(KERN_INFO - "fbcon_init: disable boot-logo (boot-logo bigger than screen).\n"); + pr_info("fbcon: disable boot-logo (boot-logo bigger than screen).\n"); } else { logo_shown = FBCON_LOGO_DRAW; vc->vc_top = logo_lines;
If the boot logo does not fit, a message is printed, including a wrong function name prefix. Instead of correcting the function name (or using __func__), just use "fbcon", like is done in several other messages. While at it, modernize the call by switching to pr_info(). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/video/fbdev/core/fbcon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)