| Message ID | 20240120213312.3033528-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3a6dd5f614a13033a47eaf439ac34e7b6fbc7705 |
| Headers | show |
| Series | riscv: remove unneeded #include <asm-generic/export.h> | expand |
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Sun, 21 Jan 2024 06:33:11 +0900 you wrote: > Commit 62694797f56b ("use linux/export.h rather than > asm-generic/export.h") replaced deprecated <asm-generic/export.h> > inclusions. > > Commit c2a658d41924 ("riscv: lib: vectorize copy_to_user/copy_from_user") > introduced a new instance of #include <asm-generic/export.h>. > > [...] Here is the summary with links: - riscv: remove unneeded #include <asm-generic/export.h> https://git.kernel.org/riscv/c/3a6dd5f614a1 You are awesome, thank you!
diff --git a/arch/riscv/lib/uaccess_vector.S b/arch/riscv/lib/uaccess_vector.S index 51ab5588e9ff..7c45f26de4f7 100644 --- a/arch/riscv/lib/uaccess_vector.S +++ b/arch/riscv/lib/uaccess_vector.S @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <linux/linkage.h> -#include <asm-generic/export.h> #include <asm/asm.h> #include <asm/asm-extable.h> #include <asm/csr.h>
Commit 62694797f56b ("use linux/export.h rather than asm-generic/export.h") replaced deprecated <asm-generic/export.h> inclusions. Commit c2a658d41924 ("riscv: lib: vectorize copy_to_user/copy_from_user") introduced a new instance of #include <asm-generic/export.h>. arch/riscv/lib/uaccess_vector.S does not use EXPORT_SYMBOL, hence this include directive is unneeded. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- I CC'ed Al Viro in case he attempts to replace <asm-generic/export.h> with <linux/export.h> again. Commit 62694797f56b was suboptimal because arch/riscv/kernel/mcount-dyn.S does not use EXPORT_SYMBOL. Removing #include <asm-generic/export.h> was correct. I had submitted a patchset earlier, but it was not picked up: https://lore.kernel.org/all/20231126151739.1557369-1-masahiroy@kernel.org/ arch/riscv/lib/uaccess_vector.S | 1 - 1 file changed, 1 deletion(-)