| Message ID | 20240112144902.40044-4-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display support for stm32f769-disco board | expand |
Hi Dario On 1/12/24 15:48, Dario Binacchi wrote: > In the schematics of document UM2033, the power supply for the micro SD > card is the same 3v3 voltage that is used to power other devices on the > board. By generalizing the name of the voltage regulator, it can be > referenced by other nodes in the device tree without creating > misunderstandings. > > This patch is preparatory for future developments. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > > --- > > Changes in v8: > - Add Reviewed-by tag of Raphael Gallais-Pou > > arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts > index 5d12ae25b327..8632bd866272 100644 > --- a/arch/arm/boot/dts/st/stm32f769-disco.dts > +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts > @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy { > clock-names = "main_clk"; > }; > > - mmc_vcard: mmc_vcard { > + vcc_3v3: vcc_3v3 { Replace node name by vcc-3v3. If no v9 sent, I'll do it directly. > compatible = "regulator-fixed"; > - regulator-name = "mmc_vcard"; > + regulator-name = "vcc_3v3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > }; > @@ -128,7 +128,7 @@ &rtc { > > &sdio2 { > status = "okay"; > - vmmc-supply = <&mmc_vcard>; > + vmmc-supply = <&vcc_3v3>; > cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>; > broken-cd; > pinctrl-names = "default", "opendrain", "sleep";
Hi Alexandre, On Tue, Jan 23, 2024 at 5:31 PM Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: > > Hi Dario > > On 1/12/24 15:48, Dario Binacchi wrote: > > In the schematics of document UM2033, the power supply for the micro SD > > card is the same 3v3 voltage that is used to power other devices on the > > board. By generalizing the name of the voltage regulator, it can be > > referenced by other nodes in the device tree without creating > > misunderstandings. > > > > This patch is preparatory for future developments. > > > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > > > > --- > > > > Changes in v8: > > - Add Reviewed-by tag of Raphael Gallais-Pou > > > > arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts > > index 5d12ae25b327..8632bd866272 100644 > > --- a/arch/arm/boot/dts/st/stm32f769-disco.dts > > +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts > > @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy { > > clock-names = "main_clk"; > > }; > > > > - mmc_vcard: mmc_vcard { > > + vcc_3v3: vcc_3v3 { > > Replace node name by vcc-3v3. If no v9 sent, I'll do it directly. I'll do it Thanks and regards, Dario > > > compatible = "regulator-fixed"; > > - regulator-name = "mmc_vcard"; > > + regulator-name = "vcc_3v3"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > }; > > @@ -128,7 +128,7 @@ &rtc { > > > > &sdio2 { > > status = "okay"; > > - vmmc-supply = <&mmc_vcard>; > > + vmmc-supply = <&vcc_3v3>; > > cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>; > > broken-cd; > > pinctrl-names = "default", "opendrain", "sleep";
diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts index 5d12ae25b327..8632bd866272 100644 --- a/arch/arm/boot/dts/st/stm32f769-disco.dts +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy { clock-names = "main_clk"; }; - mmc_vcard: mmc_vcard { + vcc_3v3: vcc_3v3 { compatible = "regulator-fixed"; - regulator-name = "mmc_vcard"; + regulator-name = "vcc_3v3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; @@ -128,7 +128,7 @@ &rtc { &sdio2 { status = "okay"; - vmmc-supply = <&mmc_vcard>; + vmmc-supply = <&vcc_3v3>; cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>; broken-cd; pinctrl-names = "default", "opendrain", "sleep";