diff mbox series

pmdomain: renesas: sort each SoC on Kconfig

Message ID 87sf2no5xo.wl-kuninori.morimoto.gx@renesas.com (mailing list archive)
State Rejected
Delegated to: Geert Uytterhoeven
Headers show
Series pmdomain: renesas: sort each SoC on Kconfig | expand

Commit Message

Kuninori Morimoto Jan. 24, 2024, 1:51 a.m. UTC 
Renesas has many SoCs and it has generation/series/model number,
but these are listed randomly in Kconfig. This patch tidyup it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/pmdomain/renesas/Kconfig | 88 +++++++++++++++++---------------
 1 file changed, 46 insertions(+), 42 deletions(-)

Comments

Geert Uytterhoeven Jan. 24, 2024, 10 a.m. UTC | #1 
Hi Morimoto-san,

Thanks for your patch!

On Wed, Jan 24, 2024 at 2:51 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Renesas has many SoCs and it has generation/series/model number,
> but these are listed randomly in Kconfig. This patch tidyup it.

They are not listed randomly, but sorted alphabetically by description,
cfr. your commit 6d5aded8d57fc032 ("soc: renesas: Sort driver
description title").  Have you changed your mind?

“A wise man changes his mind sometimes, but a fool never." ;-)

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Jan. 24, 2024, 11:26 p.m. UTC | #2 
Hi Geert

> > Renesas has many SoCs and it has generation/series/model number,
> > but these are listed randomly in Kconfig. This patch tidyup it.
> 
> They are not listed randomly, but sorted alphabetically by description,
> cfr. your commit 6d5aded8d57fc032 ("soc: renesas: Sort driver
> description title").  Have you changed your mind?

Ah..
${LINUX}/drivers/pmdomain/renesas/Kconfig was copied from
${LINUX}/drivers/soc/renesas/Kconfig.

Indeed it was alphabetically sorted, I didn't notice about it.

> “A wise man changes his mind sometimes, but a fool never." ;-)

"A wise man never forget his work, but a fool easy forget"

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
diff mbox series

Patch

diff --git a/drivers/pmdomain/renesas/Kconfig b/drivers/pmdomain/renesas/Kconfig
index 80bf2cf8b60e..2a27d83c8063 100644
--- a/drivers/pmdomain/renesas/Kconfig
+++ b/drivers/pmdomain/renesas/Kconfig
@@ -4,39 +4,34 @@  if SOC_RENESAS
 config SYSC_RCAR
 	bool "System Controller support for R-Car" if COMPILE_TEST
 
-config SYSC_RCAR_GEN4
-	bool "System Controller support for R-Car Gen4" if COMPILE_TEST
-
-config SYSC_R8A77995
-	bool "System Controller support for R-Car D3" if COMPILE_TEST
-	select SYSC_RCAR
-
-config SYSC_R8A7794
-	bool "System Controller support for R-Car E2" if COMPILE_TEST
-	select SYSC_RCAR
-
-config SYSC_R8A77990
-	bool "System Controller support for R-Car E3" if COMPILE_TEST
-	select SYSC_RCAR
+config SYSC_RMOBILE
+	bool "System Controller support for R-Mobile" if COMPILE_TEST
 
+# R-Car Gen1
 config SYSC_R8A7779
 	bool "System Controller support for R-Car H1" if COMPILE_TEST
 	select SYSC_RCAR
 
+# R-Car Gen2
 config SYSC_R8A7790
 	bool "System Controller support for R-Car H2" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A7795
-	bool "System Controller support for R-Car H3" if COMPILE_TEST
-	select SYSC_RCAR
-
 config SYSC_R8A7791
 	bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A77965
-	bool "System Controller support for R-Car M3-N" if COMPILE_TEST
+config SYSC_R8A7792
+	bool "System Controller support for R-Car V2H" if COMPILE_TEST
+	select SYSC_RCAR
+
+config SYSC_R8A7794
+	bool "System Controller support for R-Car E2" if COMPILE_TEST
+	select SYSC_RCAR
+
+# R-Car Gen3
+config SYSC_R8A7795
+	bool "System Controller support for R-Car H3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77960
@@ -47,41 +42,43 @@  config SYSC_R8A77961
 	bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A779F0
-	bool "System Controller support for R-Car S4-8" if COMPILE_TEST
-	select SYSC_RCAR_GEN4
+config SYSC_R8A77965
+	bool "System Controller support for R-Car M3-N" if COMPILE_TEST
+	select SYSC_RCAR
 
-config SYSC_R8A7792
-	bool "System Controller support for R-Car V2H" if COMPILE_TEST
+config SYSC_R8A77970
+	bool "System Controller support for R-Car V3M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77980
 	bool "System Controller support for R-Car V3H" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A77970
-	bool "System Controller support for R-Car V3M" if COMPILE_TEST
+config SYSC_R8A77990
+	bool "System Controller support for R-Car E3" if COMPILE_TEST
+	select SYSC_RCAR
+
+config SYSC_R8A77995
+	bool "System Controller support for R-Car D3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A779A0
 	bool "System Controller support for R-Car V3U" if COMPILE_TEST
 	select SYSC_RCAR_GEN4
 
+# R-Car Gen4
+config SYSC_RCAR_GEN4
+	bool "System Controller support for R-Car Gen4" if COMPILE_TEST
+
+config SYSC_R8A779F0
+	bool "System Controller support for R-Car S4-8" if COMPILE_TEST
+	select SYSC_RCAR_GEN4
+
 config SYSC_R8A779G0
 	bool "System Controller support for R-Car V4H" if COMPILE_TEST
 	select SYSC_RCAR_GEN4
 
-config SYSC_RMOBILE
-	bool "System Controller support for R-Mobile" if COMPILE_TEST
-
-config SYSC_R8A77470
-	bool "System Controller support for RZ/G1C" if COMPILE_TEST
-	select SYSC_RCAR
-
-config SYSC_R8A7745
-	bool "System Controller support for RZ/G1E" if COMPILE_TEST
-	select SYSC_RCAR
-
+# RZ/G
 config SYSC_R8A7742
 	bool "System Controller support for RZ/G1H" if COMPILE_TEST
 	select SYSC_RCAR
@@ -90,12 +87,12 @@  config SYSC_R8A7743
 	bool "System Controller support for RZ/G1M" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A774C0
-	bool "System Controller support for RZ/G2E" if COMPILE_TEST
+config SYSC_R8A7745
+	bool "System Controller support for RZ/G1E" if COMPILE_TEST
 	select SYSC_RCAR
 
-config SYSC_R8A774E1
-	bool "System Controller support for RZ/G2H" if COMPILE_TEST
+config SYSC_R8A77470
+	bool "System Controller support for RZ/G1C" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774A1
@@ -106,4 +103,11 @@  config SYSC_R8A774B1
 	bool "System Controller support for RZ/G2N" if COMPILE_TEST
 	select SYSC_RCAR
 
+config SYSC_R8A774C0
+	bool "System Controller support for RZ/G2E" if COMPILE_TEST
+	select SYSC_RCAR
+
+config SYSC_R8A774E1
+	bool "System Controller support for RZ/G2H" if COMPILE_TEST
+	select SYSC_RCAR
 endif