| Message ID | 20240124151222.1448570-6-ckeepax@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c28c45608ef35bea99a959c1643fad32e2cc4044 |
| Headers | show |
| Series | [1/6] mfd: cs42l43: Tidy up header includes | expand |
On Wed, Jan 24, 2024 at 03:12:22PM +0000, Charles Keepax wrote: > Including some missing headers. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > > The changes to the MFD headers necessitate the inclusion of of.h here to > keep things building, hence my including this SPI change in the this MFD > series. The rest of the SPI fixups will be sent separately, as they are > also not dependent on this change. If this is needed to keep things building then presumably it should be before or part of whatever change introduces the requirement, otherwise we have a bisection issue. Anyway: Acked-by: Mark Brown <broonie@kernel.org>
On Wed, Jan 24, 2024 at 03:16:25PM +0000, Mark Brown wrote: > On Wed, Jan 24, 2024 at 03:12:22PM +0000, Charles Keepax wrote: > > Including some missing headers. > > > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > > --- > > > > The changes to the MFD headers necessitate the inclusion of of.h here to > > keep things building, hence my including this SPI change in the this MFD > > series. The rest of the SPI fixups will be sent separately, as they are > > also not dependent on this change. > > If this is needed to keep things building then presumably it should be > before or part of whatever change introduces the requirement, otherwise > we have a bisection issue. Anyway: > > Acked-by: Mark Brown <broonie@kernel.org> Yup it should will, I forgot to CC Andy too, so this is a good excuse to resend :-) Thanks, Charles
diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index d239fc5a49ccc..fb62807fc991c 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -11,7 +11,9 @@ #include <linux/errno.h> #include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/regmap.h>
Including some missing headers. Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- The changes to the MFD headers necessitate the inclusion of of.h here to keep things building, hence my including this SPI change in the this MFD series. The rest of the SPI fixups will be sent separately, as they are also not dependent on this change. Thanks, Charles drivers/spi/spi-cs42l43.c | 2 ++ 1 file changed, 2 insertions(+)