| Message ID | 20240111181219.3462852-1-willy@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Convert memcontrol charge moving to use folios | expand |
On Thu, Jan 11, 2024 at 10:12 AM Matthew Wilcox (Oracle) <willy@infradead.org> wrote: > > No part of these patches should change behaviour; all the called functions > already convert from page to folio, so this ought to simply be a reduction > in the number of calls to compound_head(). > > Matthew Wilcox (Oracle) (4): > memcg: Convert mem_cgroup_move_charge_pte_range() to use a folio > memcg: Return the folio in union mc_target > memcg: Use a folio in get_mctgt_type > memcg: Use a folio in get_mctgt_type_thp > > mm/memcontrol.c | 88 ++++++++++++++++++++++++++----------------------- > 1 file changed, 46 insertions(+), 42 deletions(-) > For the series: Acked-by: Shakeel Butt <shakeelb@google.com>
Hi, On Thu 11-01-24 18:12:15, Matthew Wilcox wrote: > No part of these patches should change behaviour; all the called functions > already convert from page to folio, so this ought to simply be a reduction > in the number of calls to compound_head(). > > Matthew Wilcox (Oracle) (4): > memcg: Convert mem_cgroup_move_charge_pte_range() to use a folio > memcg: Return the folio in union mc_target > memcg: Use a folio in get_mctgt_type > memcg: Use a folio in get_mctgt_type_thp > > mm/memcontrol.c | 88 ++++++++++++++++++++++++++----------------------- > 1 file changed, 46 insertions(+), 42 deletions(-) sorry, I have missed this before. Thanks for the conversion, all seem fine. The code is rarely executed because it is not enabled by cgroup v2. But I do agree that it nicer that it fits to the new folio scheme after these patches. Acked-by: Michal Hocko <mhocko@suse.com> Thanks!