| Message ID | 20240127003607.501086-3-andre.draszik@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on | expand |
On Fri, Jan 26, 2024 at 6:37 PM André Draszik <andre.draszik@linaro.org> wrote: > > While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with > I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot > loader has configured it by the time Linux runs and it has a different > value at this stage. > > Since we want board DTS files to explicitly select the mode, we should > set it to none here so as to ensure things don't work by accident and > to make it clear that board DTS actually need to set the mode based on > the configuration. > > Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index aaac04df5e65..bc251e565be6 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -384,6 +384,7 @@ usi8: usi@109700c0 { > <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; > clock-names = "pclk", "ipclk"; > samsung,sysreg = <&sysreg_peric0 0x101c>; > + samsung,mode = <USI_V2_NONE>; > status = "disabled"; > > hsi2c_8: i2c@10970000 { > -- > 2.43.0.429.g432eaa2c6b-goog >
On 1/27/24 00:35, André Draszik wrote: > While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with > I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot > loader has configured it by the time Linux runs and it has a different > value at this stage. > ah, I didn't think about this, nor checked it. > Since we want board DTS files to explicitly select the mode, we should > set it to none here so as to ensure things don't work by accident and > to make it clear that board DTS actually need to set the mode based on > the configuration. > > Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") > Signed-off-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index aaac04df5e65..bc251e565be6 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -384,6 +384,7 @@ usi8: usi@109700c0 { > <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; > clock-names = "pclk", "ipclk"; > samsung,sysreg = <&sysreg_peric0 0x101c>; > + samsung,mode = <USI_V2_NONE>; > status = "disabled"; > > hsi2c_8: i2c@10970000 {
On Sat, 27 Jan 2024 at 00:37, André Draszik <andre.draszik@linaro.org> wrote: > > While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with > I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot > loader has configured it by the time Linux runs and it has a different > value at this stage. > > Since we want board DTS files to explicitly select the mode, we should > set it to none here so as to ensure things don't work by accident and > to make it clear that board DTS actually need to set the mode based on > the configuration. > > Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Peter Griffin <peter.griffin@linaro.org> > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index aaac04df5e65..bc251e565be6 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -384,6 +384,7 @@ usi8: usi@109700c0 { > <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; > clock-names = "pclk", "ipclk"; > samsung,sysreg = <&sysreg_peric0 0x101c>; > + samsung,mode = <USI_V2_NONE>; > status = "disabled"; > > hsi2c_8: i2c@10970000 { > -- > 2.43.0.429.g432eaa2c6b-goog >
diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index aaac04df5e65..bc251e565be6 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -384,6 +384,7 @@ usi8: usi@109700c0 { <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>; clock-names = "pclk", "ipclk"; samsung,sysreg = <&sysreg_peric0 0x101c>; + samsung,mode = <USI_V2_NONE>; status = "disabled"; hsi2c_8: i2c@10970000 {
While commit 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") states that the USI8 CONFIG is 0 at reset, the boot loader has configured it by the time Linux runs and it has a different value at this stage. Since we want board DTS files to explicitly select the mode, we should set it to none here so as to ensure things don't work by accident and to make it clear that board DTS actually need to set the mode based on the configuration. Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration") Signed-off-by: André Draszik <andre.draszik@linaro.org> --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + 1 file changed, 1 insertion(+)