| Message ID | 20240125-fix-riscv-option-arch-llvm-18-v1-0-390ac9cc3cd0@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | RISC-V: Fix CONFIG_AS_HAS_OPTION_ARCH with tip of tree LLVM | expand |
On Thu, Jan 25, 2024 at 10:32:10AM -0700, Nathan Chancellor wrote: > Hi all, > > Eric reported that builds of LLVM with [1] (close to tip of tree) have > CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on > invalid input has started succeeding. > > This Kconfig test was added because '.option arch' only causes an > assembler warning when it is unsupported, rather than a hard error, > which is what users of as-instr expect when something is unsupported. > > This can be resolved by turning assembler warnings into errors with > '-Wa,--fatal-warnings' like we do with the compiler with '-Werror', > which is what the first patch does. The second patch removes the invalid > test, as the valid test is good enough with fatal warnings. > > I have diffed several configurations for the different architectures > that use as-instr and I have found no issues. > > I think this could go in through either the kbuild or RISC-V tree with > sufficient acks but I will let them fight over who takes it :) > > [1]: https://github.com/llvm/llvm-project/commit/3ac9fe69f70a2b3541266daedbaaa7dc9c007a2a > > --- > Nathan Chancellor (2): > kbuild: Add -Wa,--fatal-warnings to as-instr invocation > RISC-V: Drop invalid test from CONFIG_AS_HAS_OPTION_ARCH > > arch/riscv/Kconfig | 1 - > scripts/Kconfig.include | 2 +- > scripts/Makefile.compiler | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) Looks good, Tested-by: Eric Biggers <ebiggers@google.com> Unfortunately another LLVM commit just broke TOOLCHAIN_HAS_VECTOR_CRYPTO, so I've sent out a patch to fix that too... But with all the fixes applied it works again. - Eric
On Sat, Jan 27, 2024 at 5:03 PM Eric Biggers <ebiggers@kernel.org> wrote: > > On Thu, Jan 25, 2024 at 10:32:10AM -0700, Nathan Chancellor wrote: > > Hi all, > > > > Eric reported that builds of LLVM with [1] (close to tip of tree) have > > CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on > > invalid input has started succeeding. > > > > This Kconfig test was added because '.option arch' only causes an > > assembler warning when it is unsupported, rather than a hard error, > > which is what users of as-instr expect when something is unsupported. > > > > This can be resolved by turning assembler warnings into errors with > > '-Wa,--fatal-warnings' like we do with the compiler with '-Werror', > > which is what the first patch does. The second patch removes the invalid > > test, as the valid test is good enough with fatal warnings. > > > > I have diffed several configurations for the different architectures > > that use as-instr and I have found no issues. > > > > I think this could go in through either the kbuild or RISC-V tree with > > sufficient acks but I will let them fight over who takes it :) > > > > [1]: https://github.com/llvm/llvm-project/commit/3ac9fe69f70a2b3541266daedbaaa7dc9c007a2a > > > > --- > > Nathan Chancellor (2): > > kbuild: Add -Wa,--fatal-warnings to as-instr invocation > > RISC-V: Drop invalid test from CONFIG_AS_HAS_OPTION_ARCH > > > > arch/riscv/Kconfig | 1 - > > scripts/Kconfig.include | 2 +- > > scripts/Makefile.compiler | 2 +- > > 3 files changed, 2 insertions(+), 3 deletions(-) > > Looks good, > > Tested-by: Eric Biggers <ebiggers@google.com> > > Unfortunately another LLVM commit just broke TOOLCHAIN_HAS_VECTOR_CRYPTO, so > I've sent out a patch to fix that too... > > But with all the fixes applied it works again. > > - Eric For this series Tested-by: Andy Chiu <andybnac@gmail.com> Reviewed-by: Andy Chiu <andybnac@gmail.com> Thanks, Andy
On Thu, Jan 25, 2024 at 10:32:10AM -0700, Nathan Chancellor wrote: > Hi all, > > Eric reported that builds of LLVM with [1] (close to tip of tree) have > CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on > invalid input has started succeeding. > > This Kconfig test was added because '.option arch' only causes an > assembler warning when it is unsupported, rather than a hard error, > which is what users of as-instr expect when something is unsupported. > > This can be resolved by turning assembler warnings into errors with > '-Wa,--fatal-warnings' like we do with the compiler with '-Werror', > which is what the first patch does. The second patch removes the invalid > test, as the valid test is good enough with fatal warnings. > > I have diffed several configurations for the different architectures > that use as-instr and I have found no issues. > > I think this could go in through either the kbuild or RISC-V tree with > sufficient acks but I will let them fight over who takes it :) I think RISC-V would be good, since building the vector crypto stuff also needs this fix. Tested-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On Tue, Jan 30, 2024 at 1:34 AM Conor Dooley <conor@kernel.org> wrote: > > On Thu, Jan 25, 2024 at 10:32:10AM -0700, Nathan Chancellor wrote: > > Hi all, > > > > Eric reported that builds of LLVM with [1] (close to tip of tree) have > > CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on > > invalid input has started succeeding. > > > > This Kconfig test was added because '.option arch' only causes an > > assembler warning when it is unsupported, rather than a hard error, > > which is what users of as-instr expect when something is unsupported. > > > > This can be resolved by turning assembler warnings into errors with > > '-Wa,--fatal-warnings' like we do with the compiler with '-Werror', > > which is what the first patch does. The second patch removes the invalid > > test, as the valid test is good enough with fatal warnings. > > > > I have diffed several configurations for the different architectures > > that use as-instr and I have found no issues. > > > > I think this could go in through either the kbuild or RISC-V tree with > > sufficient acks but I will let them fight over who takes it :) > > I think RISC-V would be good, since building the vector crypto stuff > also needs this fix. OK, then I will give ack instead of applying this series. Acked-by: Masahiro Yamada <masahiroy@kernel.org> > Tested-by: Conor Dooley <conor.dooley@microchip.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Hello: This series was applied to riscv/linux.git (fixes) by Palmer Dabbelt <palmer@rivosinc.com>: On Thu, 25 Jan 2024 10:32:10 -0700 you wrote: > Hi all, > > Eric reported that builds of LLVM with [1] (close to tip of tree) have > CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on > invalid input has started succeeding. > > This Kconfig test was added because '.option arch' only causes an > assembler warning when it is unsupported, rather than a hard error, > which is what users of as-instr expect when something is unsupported. > > [...] Here is the summary with links: - [1/2] kbuild: Add -Wa,--fatal-warnings to as-instr invocation https://git.kernel.org/riscv/c/0ee695a471a7 - [2/2] RISC-V: Drop invalid test from CONFIG_AS_HAS_OPTION_ARCH https://git.kernel.org/riscv/c/3aff0c459e77 You are awesome, thank you!
Hi all, Eric reported that builds of LLVM with [1] (close to tip of tree) have CONFIG_AS_HAS_OPTION_ARCH=n because the test for expected failure on invalid input has started succeeding. This Kconfig test was added because '.option arch' only causes an assembler warning when it is unsupported, rather than a hard error, which is what users of as-instr expect when something is unsupported. This can be resolved by turning assembler warnings into errors with '-Wa,--fatal-warnings' like we do with the compiler with '-Werror', which is what the first patch does. The second patch removes the invalid test, as the valid test is good enough with fatal warnings. I have diffed several configurations for the different architectures that use as-instr and I have found no issues. I think this could go in through either the kbuild or RISC-V tree with sufficient acks but I will let them fight over who takes it :) [1]: https://github.com/llvm/llvm-project/commit/3ac9fe69f70a2b3541266daedbaaa7dc9c007a2a --- Nathan Chancellor (2): kbuild: Add -Wa,--fatal-warnings to as-instr invocation RISC-V: Drop invalid test from CONFIG_AS_HAS_OPTION_ARCH arch/riscv/Kconfig | 1 - scripts/Kconfig.include | 2 +- scripts/Makefile.compiler | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) --- base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d change-id: 20240124-fix-riscv-option-arch-llvm-18-3cbe7b09a216 Best regards,