| Message ID | 20240130095656.3712469-3-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: mtk-socinfo: Fixes and cleanup | expand |
Il 30/01/24 10:56, Chen-Yu Tsai ha scritto: > The MT8183 has another socinfo match, with the second cell only > differing by one bit. Add it to the driver. > > Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > drivers/soc/mediatek/mtk-socinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c > index 3909d22062ce..42572e8c1520 100644 > --- a/drivers/soc/mediatek/mtk-socinfo.c > +++ b/drivers/soc/mediatek/mtk-socinfo.c > @@ -45,6 +45,7 @@ static const char *cell_names[MAX_CELLS] = {"socinfo-data1", "socinfo-data2"}; > static struct socinfo_data socinfo_data_table[] = { > MTK_SOCINFO_ENTRY("MT8173", "MT8173V/AC", "MT8173", 0x6CA20004, 0x10000000), > MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", 0x00010043, 0x00000840), > + MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", 0x00010043, 0x00000940), Are you sure that 0x940 is the same MT8183V/AZA? Added William-tw to the loop; MediaTek, can you please confirm, and please say why, there are two MT8183V/AZA with two different ChipIDs? Thanks, Angelo > MTK_SOCINFO_ENTRY("MT8186", "MT8186GV/AZA", "Kompanio 520", 0x81861001, CELL_NOT_USED), > MTK_SOCINFO_ENTRY("MT8186T", "MT8186TV/AZA", "Kompanio 528", 0x81862001, CELL_NOT_USED), > MTK_SOCINFO_ENTRY("MT8188", "MT8188GV/AZA", "Kompanio 830", 0x81880000, 0x00000010),
Acked-by: William-tw Lin <william-tw.lin@mediatek.com> On Tue, 2024-01-30 at 17:56 +0800, Chen-Yu Tsai wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > The MT8183 has another socinfo match, with the second cell only > differing by one bit. Add it to the driver. > > Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for > getting chip information") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > drivers/soc/mediatek/mtk-socinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-socinfo.c > b/drivers/soc/mediatek/mtk-socinfo.c > index 3909d22062ce..42572e8c1520 100644 > --- a/drivers/soc/mediatek/mtk-socinfo.c > +++ b/drivers/soc/mediatek/mtk-socinfo.c > @@ -45,6 +45,7 @@ static const char *cell_names[MAX_CELLS] = > {"socinfo-data1", "socinfo-data2"}; > static struct socinfo_data socinfo_data_table[] = { > MTK_SOCINFO_ENTRY("MT8173", "MT8173V/AC", "MT8173", 0x6CA20004, > 0x10000000), > MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", > 0x00010043, 0x00000840), > + MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", > 0x00010043, 0x00000940), > MTK_SOCINFO_ENTRY("MT8186", "MT8186GV/AZA", "Kompanio 520", > 0x81861001, CELL_NOT_USED), > MTK_SOCINFO_ENTRY("MT8186T", "MT8186TV/AZA", "Kompanio 528", > 0x81862001, CELL_NOT_USED), > MTK_SOCINFO_ENTRY("MT8188", "MT8188GV/AZA", "Kompanio 830", > 0x81880000, 0x00000010), > -- > 2.43.0.429.g432eaa2c6b-goog
diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c index 3909d22062ce..42572e8c1520 100644 --- a/drivers/soc/mediatek/mtk-socinfo.c +++ b/drivers/soc/mediatek/mtk-socinfo.c @@ -45,6 +45,7 @@ static const char *cell_names[MAX_CELLS] = {"socinfo-data1", "socinfo-data2"}; static struct socinfo_data socinfo_data_table[] = { MTK_SOCINFO_ENTRY("MT8173", "MT8173V/AC", "MT8173", 0x6CA20004, 0x10000000), MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", 0x00010043, 0x00000840), + MTK_SOCINFO_ENTRY("MT8183", "MT8183V/AZA", "Kompanio 500", 0x00010043, 0x00000940), MTK_SOCINFO_ENTRY("MT8186", "MT8186GV/AZA", "Kompanio 520", 0x81861001, CELL_NOT_USED), MTK_SOCINFO_ENTRY("MT8186T", "MT8186TV/AZA", "Kompanio 528", 0x81862001, CELL_NOT_USED), MTK_SOCINFO_ENTRY("MT8188", "MT8188GV/AZA", "Kompanio 830", 0x81880000, 0x00000010),
The MT8183 has another socinfo match, with the second cell only differing by one bit. Add it to the driver. Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/soc/mediatek/mtk-socinfo.c | 1 + 1 file changed, 1 insertion(+)