| Message ID | 2024013025-spoiling-exact-ad20@gregkh (mailing list archive) |
|---|---|
| Headers | show |
| Series | Soundwire: clean up sysfs group creation | expand |
On 30-01-24, 10:46, Greg Kroah-Hartman wrote: > Note, this is a redone version of a very old series I wrote back in > 2022: > https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org > but everyone has forgotten about it now, and I've reworked it, so I'm > considering it a "new" version, and not v2. > > Here's a series that adds the functionality to the driver core to hide > entire attribute groups, in a much saner way than we have attempted in > the past (i.e. dynamically figuring it out.) Many thanks to Dan for > this patch. I'll also be taking this into my driver-core branch and > creating a stable tag for anyone else to pull from to get it into their > trees, as I think it will want to be in many for this development cycle. > > After the driver core change, there's cleanups to the soundwire core for > how the attribute groups are created, to remove the "manual" creation of > them, and allow the driver core to create them correctly, as needed, > when needed, which makes things much smaller for the soundwire code to > manage. The series lgtm, having the core handle these would be good. I will wait couple of days for people to test this and give a t-b and apply. I hope it is okay if patch1 goes thru sdw tree? BR
On Wed, Jan 31, 2024 at 06:34:15PM +0530, Vinod Koul wrote: > On 30-01-24, 10:46, Greg Kroah-Hartman wrote: > > Note, this is a redone version of a very old series I wrote back in > > 2022: > > https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org > > but everyone has forgotten about it now, and I've reworked it, so I'm > > considering it a "new" version, and not v2. > > > > Here's a series that adds the functionality to the driver core to hide > > entire attribute groups, in a much saner way than we have attempted in > > the past (i.e. dynamically figuring it out.) Many thanks to Dan for > > this patch. I'll also be taking this into my driver-core branch and > > creating a stable tag for anyone else to pull from to get it into their > > trees, as I think it will want to be in many for this development cycle. > > > > After the driver core change, there's cleanups to the soundwire core for > > how the attribute groups are created, to remove the "manual" creation of > > them, and allow the driver core to create them correctly, as needed, > > when needed, which makes things much smaller for the soundwire code to > > manage. > > The series lgtm, having the core handle these would be good. I will wait > couple of days for people to test this and give a t-b and apply. > I hope it is okay if patch1 goes thru sdw tree? patch 1 is now in Linus's tree, so the remaining ones can go through the your tree now if you want. Or I can resend them if needed, just let me know. thanks, greg k-h
On 27-03-24, 09:13, Greg Kroah-Hartman wrote: > On Wed, Jan 31, 2024 at 06:34:15PM +0530, Vinod Koul wrote: > > On 30-01-24, 10:46, Greg Kroah-Hartman wrote: > > > Note, this is a redone version of a very old series I wrote back in > > > 2022: > > > https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org > > > but everyone has forgotten about it now, and I've reworked it, so I'm > > > considering it a "new" version, and not v2. > > > > > > Here's a series that adds the functionality to the driver core to hide > > > entire attribute groups, in a much saner way than we have attempted in > > > the past (i.e. dynamically figuring it out.) Many thanks to Dan for > > > this patch. I'll also be taking this into my driver-core branch and > > > creating a stable tag for anyone else to pull from to get it into their > > > trees, as I think it will want to be in many for this development cycle. > > > > > > After the driver core change, there's cleanups to the soundwire core for > > > how the attribute groups are created, to remove the "manual" creation of > > > them, and allow the driver core to create them correctly, as needed, > > > when needed, which makes things much smaller for the soundwire code to > > > manage. > > > > The series lgtm, having the core handle these would be good. I will wait > > couple of days for people to test this and give a t-b and apply. > > I hope it is okay if patch1 goes thru sdw tree? > > patch 1 is now in Linus's tree, so the remaining ones can go through the > your tree now if you want. Or I can resend them if needed, just let me > know. Great, I was about to ask about this. If there is no conflicts I can pick this series (looking at folks for giving me a t-b)
On 27/03/24 18:21, Vinod Koul wrote: > On 27-03-24, 09:13, Greg Kroah-Hartman wrote: >> On Wed, Jan 31, 2024 at 06:34:15PM +0530, Vinod Koul wrote: >>> On 30-01-24, 10:46, Greg Kroah-Hartman wrote: >>>> Note, this is a redone version of a very old series I wrote back in >>>> 2022: >>>> https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org >>>> but everyone has forgotten about it now, and I've reworked it, so I'm >>>> considering it a "new" version, and not v2. >>>> >>>> Here's a series that adds the functionality to the driver core to hide >>>> entire attribute groups, in a much saner way than we have attempted in >>>> the past (i.e. dynamically figuring it out.) Many thanks to Dan for >>>> this patch. I'll also be taking this into my driver-core branch and >>>> creating a stable tag for anyone else to pull from to get it into their >>>> trees, as I think it will want to be in many for this development cycle. >>>> >>>> After the driver core change, there's cleanups to the soundwire core for >>>> how the attribute groups are created, to remove the "manual" creation of >>>> them, and allow the driver core to create them correctly, as needed, >>>> when needed, which makes things much smaller for the soundwire code to >>>> manage. >>> The series lgtm, having the core handle these would be good. I will wait >>> couple of days for people to test this and give a t-b and apply. >>> I hope it is okay if patch1 goes thru sdw tree? >> patch 1 is now in Linus's tree, so the remaining ones can go through the >> your tree now if you want. Or I can resend them if needed, just let me >> know. > Great, I was about to ask about this. If there is no conflicts I can > pick this series (looking at folks for giving me a t-b) Applied this patch series on top of soundwire git tree and validated SoundWire stack on AMD platform using command line alsa utils. All use cases are working fine. Tested-By: Vijendar Mukunda <Vijendar.Mukunda@amd.com> >
On Tue, 30 Jan 2024 10:46:26 -0800, Greg Kroah-Hartman wrote: > Note, this is a redone version of a very old series I wrote back in > 2022: > https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org > but everyone has forgotten about it now, and I've reworked it, so I'm > considering it a "new" version, and not v2. > > Here's a series that adds the functionality to the driver core to hide > entire attribute groups, in a much saner way than we have attempted in > the past (i.e. dynamically figuring it out.) Many thanks to Dan for > this patch. I'll also be taking this into my driver-core branch and > creating a stable tag for anyone else to pull from to get it into their > trees, as I think it will want to be in many for this development cycle. > > [...] Applied, thanks! [2/6] soundwire: sysfs: move sdw_slave_dev_attr_group into the existing list of groups commit: b1b11bb07898b7e0313438734c310100219e676f [3/6] soundwire: sysfs: cleanup the logic for creating the dp0 sysfs attributes commit: 3ee43f7cc9841cdf3f2bec2de4b1e729fd17e303 [4/6] soundwire: sysfs: have the driver core handle the creation of the device groups commit: fc7e56017b51482f1b9da2e778eedb4bd1deb6b3 [5/6] soundwire: sysfs: remove sdw_slave_sysfs_init() commit: f88c1afe338edbcbfd23743742c45581075fb86c [6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments commit: 91c4dd2e5c9066577960c7eef7dd8e699220c85e Best regards,
Note, this is a redone version of a very old series I wrote back in 2022: https://lore.kernel.org/r/20220824135951.3604059-1-gregkh@linuxfoundation.org but everyone has forgotten about it now, and I've reworked it, so I'm considering it a "new" version, and not v2. Here's a series that adds the functionality to the driver core to hide entire attribute groups, in a much saner way than we have attempted in the past (i.e. dynamically figuring it out.) Many thanks to Dan for this patch. I'll also be taking this into my driver-core branch and creating a stable tag for anyone else to pull from to get it into their trees, as I think it will want to be in many for this development cycle. After the driver core change, there's cleanups to the soundwire core for how the attribute groups are created, to remove the "manual" creation of them, and allow the driver core to create them correctly, as needed, when needed, which makes things much smaller for the soundwire code to manage. Comments appreciated! thanks, greg k-h Dan Williams (1): sysfs: Introduce a mechanism to hide static attribute_groups Greg Kroah-Hartman (5): soundwire: sysfs: move sdw_slave_dev_attr_group into the existing list of groups soundwire: sysfs: cleanup the logic for creating the dp0 sysfs attributes soundwire: sysfs: have the driver core handle the creation of the device groups soundwire: sysfs: remove sdw_slave_sysfs_init() soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments drivers/soundwire/bus_type.c | 5 ++- drivers/soundwire/sysfs_local.h | 4 +- drivers/soundwire/sysfs_slave.c | 64 ++++++++++++++--------------- drivers/soundwire/sysfs_slave_dpn.c | 3 ++ fs/sysfs/group.c | 45 ++++++++++++++++---- include/linux/sysfs.h | 63 ++++++++++++++++++++++------ 6 files changed, 126 insertions(+), 58 deletions(-)