| Message ID | 20240129055147.1493853-1-Vijendar.Mukunda@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire/SOF: add SoundWire Interface support for AMD SOF stack | expand |
On Mon, 29 Jan 2024 11:21:34 +0530, Vijendar Mukunda wrote: > This patch series is to redesign existing platform device creation logic > for SoundWire managers and Implement generic functions for SoundWire > manager probe, start and exit sequence which are common for both Legacy > (NO DSP enabled) and SOF stack, and add SoundWire Interface support for > AMD SOF stack (ACP 6.3 based platform). > > Below patch series is reviewed in > https://github.com/thesofproject/linux/pull/4699 > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [01/13] ASoC/soundwire: implement generic api for scanning amd soundwire controller commit: ed0ef85795b58134172e8c82ab2f1b869cd501a6 [02/13] soundwire: amd: update license commit: a47746428cf5762290d0c55f6ef82067af04d165 [03/13] soundwire: amd: refactor amd soundwire manager device node creation commit: ed5e8741b8db908d51a26e368c18573ee1b9e208 [04/13] soundwire: amd: implement function to extract slave information commit: aff9d088a306541117e420d96ed6b6f1215a7e2d [05/13] soundwire: amd: refactor soundwire pads enable commit: cf0ddbc29dfaacb26d58a594619e42ced286ff29 [06/13] soundwire: amd: refactor register mask structure commit: c1263c75294cc8178ca964e0220b35518d6fb38d [07/13] ASoC: SOF: amd: add code for invoking soundwire manager helper functions commit: d948218424bf9194860fcc10259ff42487cf4bd9 [08/13] ASoC: SOF: amd: add interrupt handling for SoundWire manager devices commit: 96eb818510120a869711876026ca7c0aa2b4171e [09/13] ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD platforms commit: 14d89e55dec9c4e49d196b9d5d659d02dcc8252b [10/13] ASoC: SOF: amd: add machine select logic for soundwire based platforms commit: 5f97c59a77421a5e8aa3b5c4cbdda66a3c956e44 [11/13] ASoC: SOF: amd: update descriptor fields for acp6.3 based platform commit: 8af5c7e9cc89ebc6427ef8fde1de77e88ddd3e05 [12/13] ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based platform commit: 2188c2cfaa4f431c1d537bb029a6e9b0810b7e7f [13/13] ASoC: SOF: amd: refactor acp driver pm ops commit: 260b08aed4a770335ece16781d8023e9ff488ae0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Mon, Jan 29, 2024 at 11:21:34AM +0530, Vijendar Mukunda wrote: > This patch series is to redesign existing platform device creation logic > for SoundWire managers and Implement generic functions for SoundWire > manager probe, start and exit sequence which are common for both Legacy > (NO DSP enabled) and SOF stack, and add SoundWire Interface support for > AMD SOF stack (ACP 6.3 based platform). The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-soundwire-amd-v6.9 for you to fetch changes up to c1263c75294cc8178ca964e0220b35518d6fb38d: soundwire: amd: refactor register mask structure (2024-01-30 16:06:36 +0000) ---------------------------------------------------------------- soundwire: Shared branch with ASoC for AMD driver updates This branch contains the soundwire portion of a refactoring of the AMD soundwire controller and audio drivers which allows for better code sharing between DSP and non DSP case, as well as support for SOF. ---------------------------------------------------------------- Vijendar Mukunda (6): ASoC/soundwire: implement generic api for scanning amd soundwire controller soundwire: amd: update license soundwire: amd: refactor amd soundwire manager device node creation soundwire: amd: implement function to extract slave information soundwire: amd: refactor soundwire pads enable soundwire: amd: refactor register mask structure drivers/soundwire/Makefile | 2 +- drivers/soundwire/amd_init.c | 235 ++++++++++++++++++++++++++++++++++++++ drivers/soundwire/amd_init.h | 13 +++ drivers/soundwire/amd_manager.c | 47 ++------ drivers/soundwire/amd_manager.h | 16 +-- include/linux/soundwire/sdw_amd.h | 83 ++++++++++++-- sound/soc/amd/acp/Kconfig | 7 ++ sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++++ 9 files changed, 405 insertions(+), 62 deletions(-) create mode 100644 drivers/soundwire/amd_init.c create mode 100644 drivers/soundwire/amd_init.h create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c
On 31/01/24 23:21, Mark Brown wrote: > On Mon, Jan 29, 2024 at 11:21:34AM +0530, Vijendar Mukunda wrote: >> This patch series is to redesign existing platform device creation logic >> for SoundWire managers and Implement generic functions for SoundWire >> manager probe, start and exit sequence which are common for both Legacy >> (NO DSP enabled) and SOF stack, and add SoundWire Interface support for >> AMD SOF stack (ACP 6.3 based platform). > The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: > > Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-soundwire-amd-v6.9 Hi Vinod, As this patch series is merged in to sound git, Could you please let us know when this soundwire patch series will be picked in to Soundwire git. We need to send few fixes on top of this patch series. - Vijendar > > for you to fetch changes up to c1263c75294cc8178ca964e0220b35518d6fb38d: > > soundwire: amd: refactor register mask structure (2024-01-30 16:06:36 +0000) > > ---------------------------------------------------------------- > soundwire: Shared branch with ASoC for AMD driver updates > > This branch contains the soundwire portion of a refactoring of the AMD > soundwire controller and audio drivers which allows for better code > sharing between DSP and non DSP case, as well as support for SOF. > > ---------------------------------------------------------------- > Vijendar Mukunda (6): > ASoC/soundwire: implement generic api for scanning amd soundwire controller > soundwire: amd: update license > soundwire: amd: refactor amd soundwire manager device node creation > soundwire: amd: implement function to extract slave information > soundwire: amd: refactor soundwire pads enable > soundwire: amd: refactor register mask structure > > drivers/soundwire/Makefile | 2 +- > drivers/soundwire/amd_init.c | 235 ++++++++++++++++++++++++++++++++++++++ > drivers/soundwire/amd_init.h | 13 +++ > drivers/soundwire/amd_manager.c | 47 ++------ > drivers/soundwire/amd_manager.h | 16 +-- > include/linux/soundwire/sdw_amd.h | 83 ++++++++++++-- > sound/soc/amd/acp/Kconfig | 7 ++ > sound/soc/amd/acp/Makefile | 2 + > sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++++ > 9 files changed, 405 insertions(+), 62 deletions(-) > create mode 100644 drivers/soundwire/amd_init.c > create mode 100644 drivers/soundwire/amd_init.h > create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c
On 04-03-24, 12:17, Mukunda,Vijendar wrote: > On 31/01/24 23:21, Mark Brown wrote: > > On Mon, Jan 29, 2024 at 11:21:34AM +0530, Vijendar Mukunda wrote: > >> This patch series is to redesign existing platform device creation logic > >> for SoundWire managers and Implement generic functions for SoundWire > >> manager probe, start and exit sequence which are common for both Legacy > >> (NO DSP enabled) and SOF stack, and add SoundWire Interface support for > >> AMD SOF stack (ACP 6.3 based platform). > > The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: > > > > Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) > > > > are available in the Git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-soundwire-amd-v6.9 > > Hi Vinod, > > As this patch series is merged in to sound git, Could you please let us know > when this soundwire patch series will be picked in to Soundwire git. > > We need to send few fixes on top of this patch series. If you had told me earlier I would have pulled. It is late now in merge window, pls send the patches after rc1 is out in two weeks BR
On 12/03/24 19:58, Vinod Koul wrote: > On 04-03-24, 12:17, Mukunda,Vijendar wrote: >> On 31/01/24 23:21, Mark Brown wrote: >>> On Mon, Jan 29, 2024 at 11:21:34AM +0530, Vijendar Mukunda wrote: >>>> This patch series is to redesign existing platform device creation logic >>>> for SoundWire managers and Implement generic functions for SoundWire >>>> manager probe, start and exit sequence which are common for both Legacy >>>> (NO DSP enabled) and SOF stack, and add SoundWire Interface support for >>>> AMD SOF stack (ACP 6.3 based platform). >>> The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: >>> >>> Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) >>> >>> are available in the Git repository at: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-soundwire-amd-v6.9 >> Hi Vinod, >> >> As this patch series is merged in to sound git, Could you please let us know >> when this soundwire patch series will be picked in to Soundwire git. >> >> We need to send few fixes on top of this patch series. > If you had told me earlier I would have pulled. It is late now in merge > window, pls send the patches after rc1 is out in two weeks > > BR Hi Mark, As patches already got merged into for-next branch, are you going to create new tag for SoundWire patch series for RC1 release?
On Tue, Mar 12, 2024 at 09:59:09PM +0530, Mukunda,Vijendar wrote: > On 12/03/24 19:58, Vinod Koul wrote: > >> We need to send few fixes on top of this patch series. > > If you had told me earlier I would have pulled. It is late now in merge > > window, pls send the patches after rc1 is out in two weeks > As patches already got merged into for-next branch, are you going to > create new tag for SoundWire patch series for RC1 release? I'm not sure what you're expecting to be tagged here? I expect everything I currently have applied to end up in -rc1.
On 12/03/24 22:16, Mark Brown wrote: > On Tue, Mar 12, 2024 at 09:59:09PM +0530, Mukunda,Vijendar wrote: >> On 12/03/24 19:58, Vinod Koul wrote: >>>> We need to send few fixes on top of this patch series. >>> If you had told me earlier I would have pulled. It is late now in merge >>> window, pls send the patches after rc1 is out in two weeks >> As patches already got merged into for-next branch, are you going to >> create new tag for SoundWire patch series for RC1 release? > I'm not sure what you're expecting to be tagged here? I expect > everything I currently have applied to end up in -rc1. Got it. Thanks
This patch series is to redesign existing platform device creation logic for SoundWire managers and Implement generic functions for SoundWire manager probe, start and exit sequence which are common for both Legacy (NO DSP enabled) and SOF stack, and add SoundWire Interface support for AMD SOF stack (ACP 6.3 based platform). Below patch series is reviewed in https://github.com/thesofproject/linux/pull/4699 Changes since V1: - add new commit to update license for amd soundwire manager driver files. - wrap the commit message with in 75 characters. - add amd tag in commit title for soundwire patches Changes since V2: - drop "drivers" tag from commit title for SoundWire patches. changes since v3: - update copyright year - add missing blank line in sdw_amd.h file This patch series has dependencies. "soundwire: amd: refactor amd soundwire manager device node creation" patch has dependency on below patch. "ASoC/soundwire: implement generic api for scanning amd soundwire controller" Similarly SOF patches has dependency on Soundwire tree patches. This patch series has to be reviewed and merged in one go. Vijendar Mukunda (13): ASoC/soundwire: implement generic api for scanning amd soundwire controller soundwire: amd: update license soundwire: amd: refactor amd soundwire manager device node creation soundwire: amd: implement function to extract slave information soundwire: amd: refactor soundwire pads enable soundwire: amd: refactor register mask structure ASoC: SOF: amd: add code for invoking soundwire manager helper functions ASoC: SOF: amd: add interrupt handling for SoundWire manager devices ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD platforms ASoC: SOF: amd: add machine select logic for soundwire based platforms ASoC: SOF: amd: update descriptor fields for acp6.3 based platform ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based platform ASoC: SOF: amd: refactor acp driver pm ops drivers/soundwire/Makefile | 2 +- drivers/soundwire/amd_init.c | 235 +++++++++++++++++++++++++++++ drivers/soundwire/amd_init.h | 13 ++ drivers/soundwire/amd_manager.c | 47 ++---- drivers/soundwire/amd_manager.h | 16 +- include/linux/soundwire/sdw_amd.h | 83 ++++++++-- include/sound/sof/dai-amd.h | 7 + include/sound/sof/dai.h | 2 + include/uapi/sound/sof/tokens.h | 4 + sound/soc/amd/acp/Kconfig | 7 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++ sound/soc/sof/amd/Kconfig | 18 +++ sound/soc/sof/amd/acp-common.c | 65 +++++++- sound/soc/sof/amd/acp-dsp-offset.h | 10 ++ sound/soc/sof/amd/acp.c | 202 ++++++++++++++++++++++++- sound/soc/sof/amd/acp.h | 26 +++- sound/soc/sof/amd/pci-acp63.c | 7 + sound/soc/sof/ipc3-pcm.c | 25 +++ sound/soc/sof/ipc3-topology.c | 40 +++++ sound/soc/sof/sof-audio.h | 1 + sound/soc/sof/topology.c | 5 + 22 files changed, 805 insertions(+), 74 deletions(-) create mode 100644 drivers/soundwire/amd_init.c create mode 100644 drivers/soundwire/amd_init.h create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c