| Message ID | 20240201113853.37432-1-donald.hunter@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 069a6ed2992df8eaae90d69d7770de8d545327d9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v1] doc/netlink/specs: Add missing attr in rt_link spec | expand |
Thu, Feb 01, 2024 at 12:38:53PM CET, donald.hunter@gmail.com wrote: >IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which >breaks ynl. Add the missing definitions to the rt_link ynl spec. > >Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice") >Signed-off-by: Donald Hunter <donald.hunter@gmail.com> Ah, sorry about this. I wonder how could we avoid this in the future. Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 1 Feb 2024 11:38:53 +0000 you wrote: > IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which > breaks ynl. Add the missing definitions to the rt_link ynl spec. > > Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice") > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > --- > Documentation/netlink/specs/rt_link.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) Here is the summary with links: - [net,v1] doc/netlink/specs: Add missing attr in rt_link spec https://git.kernel.org/netdev/net/c/069a6ed2992d You are awesome, thank you!
diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml index 1ad01d52a863..8e4d19adee8c 100644 --- a/Documentation/netlink/specs/rt_link.yaml +++ b/Documentation/netlink/specs/rt_link.yaml @@ -942,6 +942,10 @@ attribute-sets: - name: gro-ipv4-max-size type: u32 + - + name: dpll-pin + type: nest + nested-attributes: link-dpll-pin-attrs - name: af-spec-attrs attributes: @@ -1627,6 +1631,12 @@ attribute-sets: - name: used type: u8 + - + name: link-dpll-pin-attrs + attributes: + - + name: id + type: u32 sub-messages: -
IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which breaks ynl. Add the missing definitions to the rt_link ynl spec. Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice") Signed-off-by: Donald Hunter <donald.hunter@gmail.com> --- Documentation/netlink/specs/rt_link.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)