diff mbox series

drm/panel: novatek-nt36523: Set prepare_prev_first

Message ID 20240201-topic-3623_fix-v1-1-86ee6f20876e@linaro.org (mailing list archive)
State New, archived
Headers show
Series drm/panel: novatek-nt36523: Set prepare_prev_first | expand

Commit Message

Konrad Dybcio Feb. 1, 2024, 10:17 p.m. UTC 
The .prepare callback contains the init sequence, so the DSI host *must*
be enabled at that point. Set the prepare_prev_first flag to ensure that.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/gpu/drm/panel/panel-novatek-nt36523.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62
change-id: 20240201-topic-3623_fix-9198419e5e47

Best regards,

Comments

Jessica Zhang Feb. 1, 2024, 11:15 p.m. UTC | #1 
On 2/1/2024 2:17 PM, Konrad Dybcio wrote:
> The .prepare callback contains the init sequence, so the DSI host *must*
> be enabled at that point. Set the prepare_prev_first flag to ensure that.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Hi Konrad,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> ---
>   drivers/gpu/drm/panel/panel-novatek-nt36523.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index a189ce236328..32cae1bc9162 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -1270,6 +1270,8 @@ static int nt36523_probe(struct mipi_dsi_device *dsi)
>   		return ret;
>   	}
>   
> +	pinfo->panel.prepare_prev_first = true;
> +
>   	if (pinfo->desc->has_dcs_backlight) {
>   		pinfo->panel.backlight = nt36523_create_backlight(dsi);
>   		if (IS_ERR(pinfo->panel.backlight))
> 
> ---
> base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62
> change-id: 20240201-topic-3623_fix-9198419e5e47
> 
> Best regards,
> -- 
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
Neil Armstrong Feb. 2, 2024, 9:35 p.m. UTC | #2 
Hi,

On Thu, 01 Feb 2024 23:17:40 +0100, Konrad Dybcio wrote:
> The .prepare callback contains the init sequence, so the DSI host *must*
> be enabled at that point. Set the prepare_prev_first flag to ensure that.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/panel: novatek-nt36523: Set prepare_prev_first
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d543d1b6086b18f8d8b4b26bcdf86566382a3d35
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
index a189ce236328..32cae1bc9162 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
@@ -1270,6 +1270,8 @@  static int nt36523_probe(struct mipi_dsi_device *dsi)
 		return ret;
 	}
 
+	pinfo->panel.prepare_prev_first = true;
+
 	if (pinfo->desc->has_dcs_backlight) {
 		pinfo->panel.backlight = nt36523_create_backlight(dsi);
 		if (IS_ERR(pinfo->panel.backlight))