mbox series

[6.1.y-cip,0/6] Versa3 clk driver improvements

Message ID 20240202113754.202827-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Versa3 clk driver improvements | expand

Message

Biju Das Feb. 2, 2024, 11:37 a.m. UTC
This patch series aims to improve versa3 clock driver.

All the patches are cherry-picked from the mainline.

Biju Das (6):
  arm64: defconfig: Enable Renesas VersaClock 3 clock generator config
  clk: versaclock3: Update vc3_get_div() to avoid divide by zero
  clk: versaclock3: Avoid unnecessary padding
  clk: versaclock3: Use u8 return type for get_parent() callback
  clk: versaclock3: Add missing space between ')' and '{'
  clk: versaclock3: Drop ret variable

 arch/arm64/configs/defconfig  |  1 +
 drivers/clk/clk-versaclock3.c | 88 ++++++++++++++++-------------------
 2 files changed, 41 insertions(+), 48 deletions(-)

Comments

Pavel Machek Feb. 2, 2024, 11:45 a.m. UTC | #1
Hi!

> This patch series aims to improve versa3 clock driver.
> 
> All the patches are cherry-picked from the mainline.

Series looks okay to me, I can apply it if there are no other comments
and if it passes testing.

Best regards,
								Pavel
Nobuhiro Iwamatsu Feb. 2, 2024, 12:08 p.m. UTC | #2
Hi all,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Friday, February 2, 2024 8:38 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○DITC□
> DIT○OST) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 6.1.y-cip 0/6] Versa3 clk driver improvements
> 
> This patch series aims to improve versa3 clock driver.
> 
> All the patches are cherry-picked from the mainline.
> 
> Biju Das (6):
>   arm64: defconfig: Enable Renesas VersaClock 3 clock generator config
>   clk: versaclock3: Update vc3_get_div() to avoid divide by zero
>   clk: versaclock3: Avoid unnecessary padding
>   clk: versaclock3: Use u8 return type for get_parent() callback
>   clk: versaclock3: Add missing space between ')' and '{'
>   clk: versaclock3: Drop ret variable
> 
>  arch/arm64/configs/defconfig  |  1 +
>  drivers/clk/clk-versaclock3.c | 88
> ++++++++++++++++-------------------
>  2 files changed, 41 insertions(+), 48 deletions(-)

I reviewed this series, so LGTM.
I will apply this series, if we have no other comments.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
Pavel Machek Feb. 5, 2024, 11:23 a.m. UTC | #3
Hi!

> > This patch series aims to improve versa3 clock driver.
> > 
> > All the patches are cherry-picked from the mainline.
> > 
> > Biju Das (6):
> >   arm64: defconfig: Enable Renesas VersaClock 3 clock generator config
> >   clk: versaclock3: Update vc3_get_div() to avoid divide by zero
> >   clk: versaclock3: Avoid unnecessary padding
> >   clk: versaclock3: Use u8 return type for get_parent() callback
> >   clk: versaclock3: Add missing space between ')' and '{'
> >   clk: versaclock3: Drop ret variable
> > 
> >  arch/arm64/configs/defconfig  |  1 +
> >  drivers/clk/clk-versaclock3.c | 88
> > ++++++++++++++++-------------------
> >  2 files changed, 41 insertions(+), 48 deletions(-)
> 
> I reviewed this series, so LGTM.
> I will apply this series, if we have no other comments.
> 
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Thanks for review, it tests okay, so I applied the series and pushed
it out.

Best regards,
								Pavel