diff mbox series

[net-next] net: phy: realtek: add support for RTL8126A-integrated 5Gbps PHY

Message ID 0c8e67ea-6505-43d1-bd51-94e7ecd6e222@gmail.com (mailing list archive)
State Accepted
Commit 5befa3728b855e9f75b29bb0069a1ca7f5bab2f7
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: phy: realtek: add support for RTL8126A-integrated 5Gbps PHY | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1048 this patch: 1048
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 1065 this patch: 1065
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1065 this patch: 1065
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-02-02--15-00 (tests: 720)

Commit Message

Heiner Kallweit Jan. 31, 2024, 8:24 p.m. UTC
A user reported that first consumer mainboards show up with a RTL8126A
5Gbps MAC/PHY. This adds support for the integrated PHY, which is also
available stand-alone. From a PHY driver perspective it's treated the
same as the 2.5Gbps PHY's, we just have to support the new PHY ID.

Reported-by: Joe Salmeri <jmscdba@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/realtek.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Andrew Lunn Feb. 2, 2024, 12:13 a.m. UTC | #1
On Wed, Jan 31, 2024 at 09:24:29PM +0100, Heiner Kallweit wrote:
> A user reported that first consumer mainboards show up with a RTL8126A
> 5Gbps MAC/PHY. This adds support for the integrated PHY, which is also
> available stand-alone. From a PHY driver perspective it's treated the
> same as the 2.5Gbps PHY's, we just have to support the new PHY ID.
> 
> Reported-by: Joe Salmeri <jmscdba@gmail.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Joe, can you add a Tested-by:

Otherwise, this looks O.K.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Joe Salmeri Feb. 2, 2024, 12:33 p.m. UTC | #2
On 1/31/24 15:24, Heiner Kallweit wrote:
> A user reported that first consumer mainboards show up with a RTL8126A
> 5Gbps MAC/PHY. This adds support for the integrated PHY, which is also
> available stand-alone. From a PHY driver perspective it's treated the
> same as the 2.5Gbps PHY's, we just have to support the new PHY ID.
>
> Reported-by: Joe Salmeri <jmscdba@gmail.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>   drivers/net/phy/realtek.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 894172a3e..132784321 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -1047,6 +1047,16 @@ static struct phy_driver realtek_drvs[] = {
>   		.resume         = rtlgen_resume,
>   		.read_page      = rtl821x_read_page,
>   		.write_page     = rtl821x_write_page,
> +	}, {
> +		PHY_ID_MATCH_EXACT(0x001cc862),
> +		.name           = "RTL8251B 5Gbps PHY",
> +		.get_features   = rtl822x_get_features,
> +		.config_aneg    = rtl822x_config_aneg,
> +		.read_status    = rtl822x_read_status,
> +		.suspend        = genphy_suspend,
> +		.resume         = rtlgen_resume,
> +		.read_page      = rtl821x_read_page,
> +		.write_page     = rtl821x_write_page,
>   	}, {
>   		PHY_ID_MATCH_EXACT(0x001cc961),
>   		.name		= "RTL8366RB Gigabit Ethernet",

Tested-by: Joe Salmeri <jmscdba@gmail.com>
patchwork-bot+netdevbpf@kernel.org Feb. 3, 2024, 4:50 a.m. UTC | #3
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 31 Jan 2024 21:24:29 +0100 you wrote:
> A user reported that first consumer mainboards show up with a RTL8126A
> 5Gbps MAC/PHY. This adds support for the integrated PHY, which is also
> available stand-alone. From a PHY driver perspective it's treated the
> same as the 2.5Gbps PHY's, we just have to support the new PHY ID.
> 
> Reported-by: Joe Salmeri <jmscdba@gmail.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: realtek: add support for RTL8126A-integrated 5Gbps PHY
    https://git.kernel.org/netdev/net-next/c/5befa3728b85

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 894172a3e..132784321 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -1047,6 +1047,16 @@  static struct phy_driver realtek_drvs[] = {
 		.resume         = rtlgen_resume,
 		.read_page      = rtl821x_read_page,
 		.write_page     = rtl821x_write_page,
+	}, {
+		PHY_ID_MATCH_EXACT(0x001cc862),
+		.name           = "RTL8251B 5Gbps PHY",
+		.get_features   = rtl822x_get_features,
+		.config_aneg    = rtl822x_config_aneg,
+		.read_status    = rtl822x_read_status,
+		.suspend        = genphy_suspend,
+		.resume         = rtlgen_resume,
+		.read_page      = rtl821x_read_page,
+		.write_page     = rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc961),
 		.name		= "RTL8366RB Gigabit Ethernet",