| Message ID | 20240204203127.1186621-2-andy.shevchenko@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f156743c526281ddcc19511e9073f8c987506913 |
| Headers | show |
| Series | spi: fsl-dspi: A couple of error handling improvements | expand |
On Sun, Feb 04, 2024 at 10:29:18PM +0200, andy.shevchenko@gmail.com wrote: > dmaengine_slave_config() may return different error codes based on > the circumstances. Preserve it instead of shadowing to -EINVAL. > > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index c9eae046f66c..0b5ea7a7da71 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -542,7 +542,6 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ret = dmaengine_slave_config(dma->chan_rx, &cfg); if (ret) { dev_err(dev, "can't configure rx dma channel\n"); - ret = -EINVAL; goto err_slave_config; } @@ -550,7 +549,6 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ret = dmaengine_slave_config(dma->chan_tx, &cfg); if (ret) { dev_err(dev, "can't configure tx dma channel\n"); - ret = -EINVAL; goto err_slave_config; }
dmaengine_slave_config() may return different error codes based on the circumstances. Preserve it instead of shadowing to -EINVAL. Suggested-by: Vladimir Oltean <olteanv@gmail.com> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/spi/spi-fsl-dspi.c | 2 -- 1 file changed, 2 deletions(-)