| Message ID | 20231209225135.4055334-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] mlx4: Fix spelling mistake: "mape" -> "map" | expand |
On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > There is a spelling mistake in a mlx4_err error message. Fix it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Hi Colin, I am guessing that you are focusing on error messages and other user-facing spelling errors (perhaps you told me f2f in the hallway track at Kernel Recipes). But I do wonder if you have plans to address other spelling errors in this driver. codespell flags many, including 'segements' in a comment in the same file. In any case, Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, 12 Dec 2023 20:30:43 +0000 Simon Horman wrote: > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > > There is a spelling mistake in a mlx4_err error message. Fix it. > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hi Colin, > > I am guessing that you are focusing on error messages and other user-facing > spelling errors (perhaps you told me f2f in the hallway track at Kernel > Recipes). But I do wonder if you have plans to address other spelling > errors in this driver. codespell flags many, including 'segements' in a > comment in the same file. It'd be great to fix all the codespell issues with one path, IMO.
On 12/12/2023 20:30, Simon Horman wrote: > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: >> There is a spelling mistake in a mlx4_err error message. Fix it. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hi Colin, > > I am guessing that you are focusing on error messages and other user-facing > spelling errors (perhaps you told me f2f in the hallway track at Kernel > Recipes). But I do wonder if you have plans to address other spelling > errors in this driver. codespell flags many, including 'segements' in a > comment in the same file. Yes, there are so many trivial spelling mistakes and typos across the kernel that I'm just focusing on user facing error messages for the moment. Colin > > In any case, > > Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, Dec 12, 2023 at 01:19:13PM -0800, Jakub Kicinski wrote: > On Tue, 12 Dec 2023 20:30:43 +0000 Simon Horman wrote: > > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > > > There is a spelling mistake in a mlx4_err error message. Fix it. > > > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > > Hi Colin, > > > > I am guessing that you are focusing on error messages and other user-facing > > spelling errors (perhaps you told me f2f in the hallway track at Kernel > > Recipes). But I do wonder if you have plans to address other spelling > > errors in this driver. codespell flags many, including 'segements' in a > > comment in the same file. > > It'd be great to fix all the codespell issues with one path, IMO. For the record, I have sent a follow up here: - [PATCH net-nex] mlx4: Address spelling errors https://lore.kernel.org/netdev/20240205-mlx5-codespell-v1-1-63b86dffbb61@kernel.org/
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 2581226836b5..43cbe4e5d0c4 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -1508,7 +1508,7 @@ static int mlx4_port_map_set(struct mlx4_dev *dev, struct mlx4_port_map *v2p) priv->v2p.port1 = port1; priv->v2p.port2 = port2; } else { - mlx4_err(dev, "Failed to change port mape: %d\n", err); + mlx4_err(dev, "Failed to change port map: %d\n", err); } }
There is a spelling mistake in a mlx4_err error message. Fix it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)