| Message ID | 20240204-bus_cleanup-dax-v1-1-69a6e4a8553b@marliere.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc22374c96d959084bea1287cfc6ea0fd9ca4e40 |
| Headers | show |
| Series | device-dax: make dax_bus_type const | expand |
On Sun, Feb 04, 2024 at 01:07:11PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the dax_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On 2/4/24 9:07 AM, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the dax_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dax/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index 1659b787b65f..fe0a415c854d 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -222,7 +222,7 @@ static void dax_bus_remove(struct device *dev) > dax_drv->remove(dev_dax); > } > > -static struct bus_type dax_bus_type = { > +static const struct bus_type dax_bus_type = { > .name = "dax", > .uevent = dax_bus_uevent, > .match = dax_bus_match, > > --- > base-commit: 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5 > change-id: 20240204-bus_cleanup-dax-52c34f72615f > > Best regards,
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 1659b787b65f..fe0a415c854d 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -222,7 +222,7 @@ static void dax_bus_remove(struct device *dev) dax_drv->remove(dev_dax); } -static struct bus_type dax_bus_type = { +static const struct bus_type dax_bus_type = { .name = "dax", .uevent = dax_bus_uevent, .match = dax_bus_match,
Now that the driver core can properly handle constant struct bus_type, move the dax_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5 change-id: 20240204-bus_cleanup-dax-52c34f72615f Best regards,