| Message ID | 20240206001333.1710070-4-yoann.congal@smile.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | printk: CONFIG_BASE_SMALL fix for LOG_CPU_MAX_BUF_SHIFT and removal of CONFIG_BASE_FULL | expand |
On Tue 2024-02-06 01:13:33, Yoann Congal wrote: > CONFIG_BASE_FULL is equivalent to !CONFIG_BASE_SMALL and is enabled by > default: CONFIG_BASE_SMALL is the special case to take care of. > So, remove CONFIG_BASE_FULL and move the config choice to > CONFIG_BASE_SMALL (which defaults to 'n') > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> This might also require updatating the default config files which unset CONFIG_BASE_FULL. I mean: $> git grep BASE_FULL arch/ arch/arm/configs/collie_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/keystone_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/lpc18xx_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/moxart_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/mps2_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/omap1_defconfig:# CONFIG_BASE_FULL is not set arch/arm/configs/stm32_defconfig:# CONFIG_BASE_FULL is not set arch/microblaze/configs/mmu_defconfig:# CONFIG_BASE_FULL is not set arch/mips/configs/rs90_defconfig:# CONFIG_BASE_FULL is not set arch/powerpc/configs/adder875_defconfig:# CONFIG_BASE_FULL is not set arch/powerpc/configs/ep88xc_defconfig:# CONFIG_BASE_FULL is not set arch/powerpc/configs/mpc866_ads_defconfig:# CONFIG_BASE_FULL is not set arch/powerpc/configs/mpc885_ads_defconfig:# CONFIG_BASE_FULL is not set arch/powerpc/configs/tqm8xx_defconfig:# CONFIG_BASE_FULL is not set arch/riscv/configs/nommu_k210_defconfig:# CONFIG_BASE_FULL is not set arch/riscv/configs/nommu_k210_sdcard_defconfig:# CONFIG_BASE_FULL is not set arch/riscv/configs/nommu_virt_defconfig:# CONFIG_BASE_FULL is not set arch/sh/configs/edosk7705_defconfig:# CONFIG_BASE_FULL is not set arch/sh/configs/se7619_defconfig:# CONFIG_BASE_FULL is not set arch/sh/configs/se7712_defconfig:# CONFIG_BASE_FULL is not set arch/sh/configs/se7721_defconfig:# CONFIG_BASE_FULL is not set arch/sh/configs/shmin_defconfig:# CONFIG_BASE_FULL is not set Best Regards, Petr
On Tue 2024-02-06 10:04:20, Petr Mladek wrote: > On Tue 2024-02-06 01:13:33, Yoann Congal wrote: > > CONFIG_BASE_FULL is equivalent to !CONFIG_BASE_SMALL and is enabled by > > default: CONFIG_BASE_SMALL is the special case to take care of. > > So, remove CONFIG_BASE_FULL and move the config choice to > > CONFIG_BASE_SMALL (which defaults to 'n') > > > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> > > This might also require updatating the default config files which > unset CONFIG_BASE_FULL. I mean: > > $> git grep BASE_FULL arch/ > arch/arm/configs/collie_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/keystone_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/lpc18xx_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/moxart_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/mps2_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/omap1_defconfig:# CONFIG_BASE_FULL is not set > arch/arm/configs/stm32_defconfig:# CONFIG_BASE_FULL is not set > arch/microblaze/configs/mmu_defconfig:# CONFIG_BASE_FULL is not set > arch/mips/configs/rs90_defconfig:# CONFIG_BASE_FULL is not set > arch/powerpc/configs/adder875_defconfig:# CONFIG_BASE_FULL is not set > arch/powerpc/configs/ep88xc_defconfig:# CONFIG_BASE_FULL is not set > arch/powerpc/configs/mpc866_ads_defconfig:# CONFIG_BASE_FULL is not set > arch/powerpc/configs/mpc885_ads_defconfig:# CONFIG_BASE_FULL is not set > arch/powerpc/configs/tqm8xx_defconfig:# CONFIG_BASE_FULL is not set > arch/riscv/configs/nommu_k210_defconfig:# CONFIG_BASE_FULL is not set > arch/riscv/configs/nommu_k210_sdcard_defconfig:# CONFIG_BASE_FULL is not set > arch/riscv/configs/nommu_virt_defconfig:# CONFIG_BASE_FULL is not set > arch/sh/configs/edosk7705_defconfig:# CONFIG_BASE_FULL is not set > arch/sh/configs/se7619_defconfig:# CONFIG_BASE_FULL is not set > arch/sh/configs/se7712_defconfig:# CONFIG_BASE_FULL is not set > arch/sh/configs/se7721_defconfig:# CONFIG_BASE_FULL is not set > arch/sh/configs/shmin_defconfig:# CONFIG_BASE_FULL is not set Ah, also we should drop: tools/testing/selftests/wireguard/qemu/kernel.config:CONFIG_BASE_FULL=y Best Regards, Petr
On Tue, Feb 6, 2024 at 9:13 AM Yoann Congal <yoann.congal@smile.fr> wrote: > > CONFIG_BASE_FULL is equivalent to !CONFIG_BASE_SMALL and is enabled by > default: CONFIG_BASE_SMALL is the special case to take care of. > So, remove CONFIG_BASE_FULL and move the config choice to > CONFIG_BASE_SMALL (which defaults to 'n') > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> > --- > v3->v4: > * Split "switch CONFIG_BASE_SMALL to bool" and "Remove the redundant > config" (this patch) into two patches > * keep CONFIG_BASE_SMALL instead of CONFIG_BASE_FULL > --- > init/Kconfig | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index d4b16cad98502..4ecf2572d00ee 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1581,11 +1581,11 @@ config PCSPKR_PLATFORM > This option allows to disable the internal PC-Speaker > support, saving some memory. > > -config BASE_FULL > - default y > - bool "Enable full-sized data structures for core" if EXPERT > +config BASE_SMALL > + default n A nit. Please drop the redundant 'default n' next time (as it seems you will have a change to send v5) > + bool "Enable smaller-sized data structures for core" if EXPERT > help > - Disabling this option reduces the size of miscellaneous core > + Enabling this option reduces the size of miscellaneous core > kernel data structures. This saves memory on small machines, > but may reduce performance. > > @@ -1940,11 +1940,6 @@ config RT_MUTEXES > bool > default y if PREEMPT_RT > > -config BASE_SMALL > - bool > - default y if !BASE_FULL > - default n > - > config MODULE_SIG_FORMAT > def_bool n > select SYSTEM_DATA_VERIFICATION > -- > 2.39.2 >
diff --git a/init/Kconfig b/init/Kconfig index d4b16cad98502..4ecf2572d00ee 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1581,11 +1581,11 @@ config PCSPKR_PLATFORM This option allows to disable the internal PC-Speaker support, saving some memory. -config BASE_FULL - default y - bool "Enable full-sized data structures for core" if EXPERT +config BASE_SMALL + default n + bool "Enable smaller-sized data structures for core" if EXPERT help - Disabling this option reduces the size of miscellaneous core + Enabling this option reduces the size of miscellaneous core kernel data structures. This saves memory on small machines, but may reduce performance. @@ -1940,11 +1940,6 @@ config RT_MUTEXES bool default y if PREEMPT_RT -config BASE_SMALL - bool - default y if !BASE_FULL - default n - config MODULE_SIG_FORMAT def_bool n select SYSTEM_DATA_VERIFICATION
CONFIG_BASE_FULL is equivalent to !CONFIG_BASE_SMALL and is enabled by default: CONFIG_BASE_SMALL is the special case to take care of. So, remove CONFIG_BASE_FULL and move the config choice to CONFIG_BASE_SMALL (which defaults to 'n') Signed-off-by: Yoann Congal <yoann.congal@smile.fr> --- v3->v4: * Split "switch CONFIG_BASE_SMALL to bool" and "Remove the redundant config" (this patch) into two patches * keep CONFIG_BASE_SMALL instead of CONFIG_BASE_FULL --- init/Kconfig | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)