| Message ID | 20240207131113.2450297-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Felix Fietkau |
| Headers | show |
| Series | [next] mt76: Remove redundant assignment to variable tidno | expand |
Colin Ian King <colin.i.king@gmail.com> writes: > The variable tidno is being assigned a value that is not being read > and is being re-assigned a new value a few statements later. > The assignment is redundant and can be removed. > > Cleans up clang scan warning: > drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored > to 'tidno' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> "wifi:" missing from title.
On 07/02/2024 13:31, Kalle Valo wrote: > Colin Ian King <colin.i.king@gmail.com> writes: > >> The variable tidno is being assigned a value that is not being read >> and is being re-assigned a new value a few statements later. >> The assignment is redundant and can be removed. >> >> Cleans up clang scan warning: >> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored >> to 'tidno' during its initialization is never read [deadcode.DeadStores] >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > "wifi:" missing from title. > does this require a V2?
"Colin King (gmail)" <colin.i.king@gmail.com> writes: > On 07/02/2024 13:31, Kalle Valo wrote: >> Colin Ian King <colin.i.king@gmail.com> writes: >> >>> The variable tidno is being assigned a value that is not being read >>> and is being re-assigned a new value a few statements later. >>> The assignment is redundant and can be removed. >>> >>> Cleans up clang scan warning: >>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored >>> to 'tidno' during its initialization is never read [deadcode.DeadStores] >>> >>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >> "wifi:" missing from title. >> > does this require a V2? Up to Felix, my guess is that he can add it during commit.
Il 07/02/24 14:11, Colin Ian King ha scritto: > The variable tidno is being assigned a value that is not being read > and is being re-assigned a new value a few statements later. > The assignment is redundant and can be removed. > > Cleans up clang scan warning: > drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored > to 'tidno' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c > index 10cbd9e560e7..07c386c7b4d0 100644 > --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c > +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c > @@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames) > struct ieee80211_bar *bar = mt76_skb_get_hdr(skb); > struct mt76_wcid *wcid = status->wcid; > struct mt76_rx_tid *tid; > - u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK; > + u8 tidno; > u16 seqno; > > if (!ieee80211_is_ctl(bar->frame_control))
diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c index 10cbd9e560e7..07c386c7b4d0 100644 --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c @@ -122,7 +122,7 @@ mt76_rx_aggr_check_ctl(struct sk_buff *skb, struct sk_buff_head *frames) struct ieee80211_bar *bar = mt76_skb_get_hdr(skb); struct mt76_wcid *wcid = status->wcid; struct mt76_rx_tid *tid; - u8 tidno = status->qos_ctl & IEEE80211_QOS_CTL_TID_MASK; + u8 tidno; u16 seqno; if (!ieee80211_is_ctl(bar->frame_control))
The variable tidno is being assigned a value that is not being read and is being re-assigned a new value a few statements later. The assignment is redundant and can be removed. Cleans up clang scan warning: drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored to 'tidno' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)