| Message ID | Zb9/O81fVAZw4ANr@shell.armlinux.org.uk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: eee network driver cleanups | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 4 Feb 2024 12:12:43 +0000 you wrote: > Hi, > > Since commit d1420bb99515 ("net: phy: improve generic EEE ethtool > functions") changed phylib to set eee->eee_active and eee->eee_enabled, > overriding anything that drivers have set these to prior to calling > phy_ethtool_get_eee(). > > [...] Here is the summary with links: - [net-next,v2,1/6] net: stmmac: remove eee_enabled/eee_active in stmmac_ethtool_op_get_eee() https://git.kernel.org/netdev/net-next/c/0cb6daf549f9 - [net-next,v2,2/6] net: sxgbe: remove eee_enabled/eee_active in sxgbe_get_eee() https://git.kernel.org/netdev/net-next/c/d0d8c548789d - [net-next,v2,3/6] net: fec: remove eee_enabled/eee_active in fec_enet_get_eee() https://git.kernel.org/netdev/net-next/c/b573cb0a5586 - [net-next,v2,4/6] net: bcmgenet: remove eee_enabled/eee_active in bcmgenet_get_eee() https://git.kernel.org/netdev/net-next/c/409359c1c2ef - [net-next,v2,5/6] net: bcmasp: remove eee_enabled/eee_active in bcmasp_get_eee() https://git.kernel.org/netdev/net-next/c/0cbfdfe3fb80 - [net-next,v2,6/6] net: dsa: b53: remove eee_enabled/eee_active in b53_get_mac_eee() https://git.kernel.org/netdev/net-next/c/3465df5533af You are awesome, thank you!
Hi, Since commit d1420bb99515 ("net: phy: improve generic EEE ethtool functions") changed phylib to set eee->eee_active and eee->eee_enabled, overriding anything that drivers have set these to prior to calling phy_ethtool_get_eee(). Therefore, drivers setting these members becomes redundant, since phylib overwrites the values they set. This series finishes off Heiner's work in the referenced commit by removing these redundant writes in various drivers and any associated code or structure members that become unnecessary. v2: Address Andrew's comment on fec_main.c drivers/net/dsa/b53/b53_common.c | 6 ------ drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c | 4 ---- drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 5 +++-- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 +++----- drivers/net/ethernet/broadcom/genet/bcmmii.c | 5 +++-- drivers/net/ethernet/freescale/fec_main.c | 4 ---- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 1 - drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c | 2 -- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 1 - drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 -- 10 files changed, 9 insertions(+), 29 deletions(-)