| Message ID | 20240207171524.2458418-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b53adefc884ce470a5b27885466439cbb087813e |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [next] carl9170: Remove redundant assignment to pointer super | expand |
Colin Ian King <colin.i.king@gmail.com> writes: > The pointer super is being assigned a value that is not being read, it > is being re-assigned later. The assignment is redundant and can be > removed. > > Cleans up clang scan warning: > drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to > 'super' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Same here, "wifi:" missing. I can add it, no need to resend because of this.
On 2/7/24 18:15, Colin Ian King wrote: > The pointer super is being assigned a value that is not being read, it > is being re-assigned later. The assignment is redundant and can be > removed. > > Cleans up clang scan warning: > drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to > 'super' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Christian Lamparter <chunkeey@gmail.com> > --- > drivers/net/wireless/ath/carl9170/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c > index 6bb9aa2bfe65..e902ca80eba7 100644 > --- a/drivers/net/wireless/ath/carl9170/tx.c > +++ b/drivers/net/wireless/ath/carl9170/tx.c > @@ -189,7 +189,7 @@ static void carl9170_tx_accounting_free(struct ar9170 *ar, struct sk_buff *skb) > > static int carl9170_alloc_dev_space(struct ar9170 *ar, struct sk_buff *skb) > { > - struct _carl9170_tx_superframe *super = (void *) skb->data; > + struct _carl9170_tx_superframe *super; > unsigned int chunks; > int cookie = -1; >
Colin Ian King <colin.i.king@gmail.com> wrote: > The pointer super is being assigned a value that is not being read, it > is being re-assigned later. The assignment is redundant and can be > removed. > > Cleans up clang scan warning: > > drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to > 'super' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > Acked-by: Christian Lamparter <chunkeey@gmail.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. b53adefc884c wifi: carl9170: Remove redundant assignment to pointer super
diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c index 6bb9aa2bfe65..e902ca80eba7 100644 --- a/drivers/net/wireless/ath/carl9170/tx.c +++ b/drivers/net/wireless/ath/carl9170/tx.c @@ -189,7 +189,7 @@ static void carl9170_tx_accounting_free(struct ar9170 *ar, struct sk_buff *skb) static int carl9170_alloc_dev_space(struct ar9170 *ar, struct sk_buff *skb) { - struct _carl9170_tx_superframe *super = (void *) skb->data; + struct _carl9170_tx_superframe *super; unsigned int chunks; int cookie = -1;
The pointer super is being assigned a value that is not being read, it is being re-assigned later. The assignment is redundant and can be removed. Cleans up clang scan warning: drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to 'super' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/wireless/ath/carl9170/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)