| Message ID | 20240206112927.4134375-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 83acbb9d0716c7f787d248ca982f4a4a895aef65 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb() | expand |
On Tue, Feb 06, 2024 at 01:29:26PM +0200, Vladimir Oltean wrote: > The convention is to not use "inline" functions in C files, and let the > compiler decide whether to inline or not. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 6 Feb 2024 13:29:26 +0200 you wrote: > The convention is to not use "inline" functions in C files, and let the > compiler decide whether to inline or not. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > net/dsa/user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next,1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb() https://git.kernel.org/netdev/net-next/c/83acbb9d0716 - [net-next,2/2] net: dsa: tag_sja1105: remove "inline" keyword https://git.kernel.org/netdev/net-next/c/36f75f74dc07 You are awesome, thank you!
diff --git a/net/dsa/user.c b/net/dsa/user.c index ba2e53b5e16a..5d666dfb317d 100644 --- a/net/dsa/user.c +++ b/net/dsa/user.c @@ -875,8 +875,8 @@ static int dsa_user_port_obj_del(struct net_device *dev, const void *ctx, return err; } -static inline netdev_tx_t dsa_user_netpoll_send_skb(struct net_device *dev, - struct sk_buff *skb) +static netdev_tx_t dsa_user_netpoll_send_skb(struct net_device *dev, + struct sk_buff *skb) { #ifdef CONFIG_NET_POLL_CONTROLLER struct dsa_user_priv *p = netdev_priv(dev);
The convention is to not use "inline" functions in C files, and let the compiler decide whether to inline or not. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- net/dsa/user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)