| Message ID | 20240125102413.3016-3-quic_lxu5@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: Add dma-coherent property on | expand |
On 25/01/2024 11:24, Ling Xu wrote: > Add dma-coherent property to fastRPC context bank nodes to pass dma > sequence test in fastrpc sanity test, ensure that data integrity is > maintained during DMA operations. > > Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ This wasn't ever tested: sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' Ling, How is this testing-patches-before-sending work in different teams? Do you have such requirement? Best regards, Krzysztof
On 12/02/2024 12:00, Krzysztof Kozlowski wrote: > On 25/01/2024 11:24, Ling Xu wrote: >> Add dma-coherent property to fastRPC context bank nodes to pass dma >> sequence test in fastrpc sanity test, ensure that data integrity is >> maintained during DMA operations. >> >> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ > > This wasn't ever tested: > > sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: > 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' > > Ling, > How is this testing-patches-before-sending work in different teams? Do > you have such requirement? No clue if the original DTS change should be reverted or these are in fact DMA coherent, but let's choose one path... https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t Best regards, Krzysztof
在 2024/2/12 19:10, Krzysztof Kozlowski 写道: > On 12/02/2024 12:00, Krzysztof Kozlowski wrote: >> On 25/01/2024 11:24, Ling Xu wrote: >>> Add dma-coherent property to fastRPC context bank nodes to pass dma >>> sequence test in fastrpc sanity test, ensure that data integrity is >>> maintained during DMA operations. >>> >>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ >> >> This wasn't ever tested: >> >> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: >> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >> >> Ling, >> How is this testing-patches-before-sending work in different teams? Do >> you have such requirement? > > No clue if the original DTS change should be reverted or these are in > fact DMA coherent, but let's choose one path... > > https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t > > Best regards, > Krzysztof > Hi Krzysztof, Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
On 12/02/2024 12:31, Ling Xu wrote: > 在 2024/2/12 19:10, Krzysztof Kozlowski 写道: >> On 12/02/2024 12:00, Krzysztof Kozlowski wrote: >>> On 25/01/2024 11:24, Ling Xu wrote: >>>> Add dma-coherent property to fastRPC context bank nodes to pass dma >>>> sequence test in fastrpc sanity test, ensure that data integrity is >>>> maintained during DMA operations. >>>> >>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ >>> >>> This wasn't ever tested: >>> >>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: >>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>> >>> Ling, >>> How is this testing-patches-before-sending work in different teams? Do >>> you have such requirement? >> >> No clue if the original DTS change should be reverted or these are in >> fact DMA coherent, but let's choose one path... >> >> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck. I don't understand your comment. Did you read the link above? Anyway, I was asking: are you testing the patches before sending? Best regards, Krzysztof
在 2024/2/12 19:41, Krzysztof Kozlowski 写道: > On 12/02/2024 12:31, Ling Xu wrote: >> 在 2024/2/12 19:10, Krzysztof Kozlowski 写道: >>> On 12/02/2024 12:00, Krzysztof Kozlowski wrote: >>>> On 25/01/2024 11:24, Ling Xu wrote: >>>>> Add dma-coherent property to fastRPC context bank nodes to pass dma >>>>> sequence test in fastrpc sanity test, ensure that data integrity is >>>>> maintained during DMA operations. >>>>> >>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ >>>> >>>> This wasn't ever tested: >>>> >>>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1: >>>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>> >>>> Ling, >>>> How is this testing-patches-before-sending work in different teams? Do >>>> you have such requirement? >>> >>> No clue if the original DTS change should be reverted or these are in >>> fact DMA coherent, but let's choose one path... >>> >>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t >>> >>> Best regards, >>> Krzysztof >>> >> Hi Krzysztof, >> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck. > > I don't understand your comment. Did you read the link above? > > Anyway, I was asking: are you testing the patches before sending? > > Best regards, > Krzysztof > Yes, I tested before sending.
On 12/02/2024 12:45, Ling Xu wrote: >>>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> Hi Krzysztof, >>> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck. >> >> I don't understand your comment. Did you read the link above? >> >> Anyway, I was asking: are you testing the patches before sending? >> >> Best regards, >> Krzysztof >> > Yes, I tested before sending. Then I am confused why there is a warning. If this was tested and sent, it means you sent code with a known warning. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 2df77123a8c7..ed0d0ca34fd4 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4808,6 +4808,7 @@ iommus = <&apps_smmu 0x1003 0x80>, <&apps_smmu 0x1043 0x20>; + dma-coherent; }; compute-cb@4 { @@ -4816,6 +4817,7 @@ iommus = <&apps_smmu 0x1004 0x80>, <&apps_smmu 0x1044 0x20>; + dma-coherent; }; compute-cb@5 { @@ -4824,6 +4826,7 @@ iommus = <&apps_smmu 0x1005 0x80>, <&apps_smmu 0x1045 0x20>; + dma-coherent; }; compute-cb@6 { @@ -4832,6 +4835,7 @@ iommus = <&apps_smmu 0x1006 0x80>, <&apps_smmu 0x1046 0x20>; + dma-coherent; }; compute-cb@7 { @@ -4841,6 +4845,7 @@ iommus = <&apps_smmu 0x1007 0x40>, <&apps_smmu 0x1067 0x0>, <&apps_smmu 0x1087 0x0>; + dma-coherent; }; }; @@ -4961,6 +4966,7 @@ iommus = <&apps_smmu 0x1961 0x0>, <&apps_smmu 0x0c01 0x20>, <&apps_smmu 0x19c1 0x0>; + dma-coherent; }; compute-cb@2 { @@ -4970,6 +4976,7 @@ iommus = <&apps_smmu 0x1962 0x0>, <&apps_smmu 0x0c02 0x20>, <&apps_smmu 0x19c2 0x0>; + dma-coherent; }; compute-cb@3 { @@ -4979,6 +4986,7 @@ iommus = <&apps_smmu 0x1963 0x0>, <&apps_smmu 0x0c03 0x20>, <&apps_smmu 0x19c3 0x0>; + dma-coherent; }; compute-cb@4 { @@ -4988,6 +4996,7 @@ iommus = <&apps_smmu 0x1964 0x0>, <&apps_smmu 0x0c04 0x20>, <&apps_smmu 0x19c4 0x0>; + dma-coherent; }; compute-cb@5 { @@ -4997,6 +5006,7 @@ iommus = <&apps_smmu 0x1965 0x0>, <&apps_smmu 0x0c05 0x20>, <&apps_smmu 0x19c5 0x0>; + dma-coherent; }; compute-cb@6 { @@ -5006,6 +5016,7 @@ iommus = <&apps_smmu 0x1966 0x0>, <&apps_smmu 0x0c06 0x20>, <&apps_smmu 0x19c6 0x0>; + dma-coherent; }; compute-cb@7 { @@ -5015,6 +5026,7 @@ iommus = <&apps_smmu 0x1967 0x0>, <&apps_smmu 0x0c07 0x20>, <&apps_smmu 0x19c7 0x0>; + dma-coherent; }; compute-cb@8 { @@ -5024,6 +5036,7 @@ iommus = <&apps_smmu 0x1968 0x0>, <&apps_smmu 0x0c08 0x20>, <&apps_smmu 0x19c8 0x0>; + dma-coherent; }; }; };
Add dma-coherent property to fastRPC context bank nodes to pass dma sequence test in fastrpc sanity test, ensure that data integrity is maintained during DMA operations. Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)