| Message ID | 20240212-topic-sm8650-gpu-v1-5-708a40b747b5@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm: Add support for the A750 GPU found on the SM8650 platform | expand |
On 12.02.2024 11:37, Neil Armstrong wrote: > Add path of the GPU firmware for the SM8650-QRD board > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Mon, 12 Feb 2024 at 12:37, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Add path of the GPU firmware for the SM8650-QRD board > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > index 8515498553bf..7151f3dc67c4 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > @@ -525,6 +525,14 @@ &ipa { > status = "okay"; > }; > > +&gpu { > + status = "okay"; > + > + zap-shader { > + firmware-name = "qcom/sm8650/gen70900_zap.mbn"; But why? For sm8450 / sm8550 we had "a730_zap.mbn" and "a740_zap.mbn" > + }; > +}; > + > &mdss { > status = "okay"; > }; > > -- > 2.34.1 >
Hi, On 12/02/2024 14:32, Dmitry Baryshkov wrote: > On Mon, 12 Feb 2024 at 12:37, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Add path of the GPU firmware for the SM8650-QRD board >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> index 8515498553bf..7151f3dc67c4 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> @@ -525,6 +525,14 @@ &ipa { >> status = "okay"; >> }; >> >> +&gpu { >> + status = "okay"; >> + >> + zap-shader { >> + firmware-name = "qcom/sm8650/gen70900_zap.mbn"; > > But why? For sm8450 / sm8550 we had "a730_zap.mbn" and "a740_zap.mbn" No idea why, this is the vendor's fw name, it uses the chipid (2 for sm8550, 9 for sm8650) instead of the commercial name like the seq file (gen70900_sqe.fw). Neil > >> + }; >> +}; >> + >> &mdss { >> status = "okay"; >> }; >> >> -- >> 2.34.1 >> > >
diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts index 8515498553bf..7151f3dc67c4 100644 --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts @@ -525,6 +525,14 @@ &ipa { status = "okay"; }; +&gpu { + status = "okay"; + + zap-shader { + firmware-name = "qcom/sm8650/gen70900_zap.mbn"; + }; +}; + &mdss { status = "okay"; };
Add path of the GPU firmware for the SM8650-QRD board Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 8 ++++++++ 1 file changed, 8 insertions(+)