| Message ID | 20240210070934.2549994-2-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | platform/chrome: Add DT USB/DP muxing/topology to Trogdor | expand |
On 10/02/2024 08:09, Stephen Boyd wrote: > The ChromeOS embedded controller (EC) supports setting the state of > GPIOs when the system is unlocked, and getting the state of GPIOs in all > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > expander. Add a binding to describe these GPIOs in DT so that other > devices described in DT can read the GPIOs on the EC. ... > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cros-ec@0 { > + compatible = "google,cros-ec-spi"; > + reg = <0>; > + interrupts = <101 0>; This is should be proper define but then are you sure interrupt is type NONE? Does not look right. Best regards, Krzysztof
Quoting Krzysztof Kozlowski (2024-02-11 05:26:33) > On 10/02/2024 08:09, Stephen Boyd wrote: > > The ChromeOS embedded controller (EC) supports setting the state of > > GPIOs when the system is unlocked, and getting the state of GPIOs in all > > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > > expander. Add a binding to describe these GPIOs in DT so that other > > devices described in DT can read the GPIOs on the EC. > > ... > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cros-ec@0 { > > + compatible = "google,cros-ec-spi"; > > + reg = <0>; > > + interrupts = <101 0>; > > This is should be proper define but then are you sure interrupt is type > NONE? Does not look right. > I copied this from cros-ec-typec.yaml so I'll have to fix them all!
On Fri, Feb 09, 2024 at 11:09:12PM -0800, Stephen Boyd wrote: > The ChromeOS embedded controller (EC) supports setting the state of > GPIOs when the system is unlocked, and getting the state of GPIOs in all > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > expander. Add a binding to describe these GPIOs in DT so that other > devices described in DT can read the GPIOs on the EC. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Lee Jones <lee@kernel.org> > Cc: Benson Leung <bleung@chromium.org> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: <linux-gpio@vger.kernel.org> > Cc: <devicetree@vger.kernel.org> > Cc: <chrome-platform@lists.linux.dev> > Cc: Pin-yen Lin <treapking@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > .../bindings/gpio/google,cros-ec-gpio.yaml | 49 +++++++++++++++++++ > .../bindings/mfd/google,cros-ec.yaml | 3 ++ > 2 files changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml b/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml > new file mode 100644 > index 000000000000..a9f1d7784070 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/google,cros-ec-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIOs controlled by ChromeOS EC > + > +maintainers: > + - Stephen Boyd <swboyd@chromium.org> > + > +description: > + Google's ChromeOS EC has a gpio controller inside the Embedded Controller > + (EC) and controlled via a host-command interface. The node for this > + device should be under a cros-ec node like google,cros-ec-spi. Why do we need a child node here? Rob
Quoting Rob Herring (2024-02-15 06:06:38) > On Fri, Feb 09, 2024 at 11:09:12PM -0800, Stephen Boyd wrote: > > + > > +description: > > + Google's ChromeOS EC has a gpio controller inside the Embedded Controller > > + (EC) and controlled via a host-command interface. The node for this > > + device should be under a cros-ec node like google,cros-ec-spi. > > Why do we need a child node here? > When in Rome... but I get your point. I will work on moving #gpio-cells and gpio-controller into the cros-ec binding and populating some child device from the mfd driver.
diff --git a/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml b/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml new file mode 100644 index 000000000000..a9f1d7784070 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/google,cros-ec-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIOs controlled by ChromeOS EC + +maintainers: + - Stephen Boyd <swboyd@chromium.org> + +description: + Google's ChromeOS EC has a gpio controller inside the Embedded Controller + (EC) and controlled via a host-command interface. The node for this + device should be under a cros-ec node like google,cros-ec-spi. + +properties: + compatible: + const: google,cros-ec-gpio + + '#gpio-cells': + const: 2 + + gpio-controller: true + +required: + - compatible + - '#gpio-cells' + - gpio-controller + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + cros-ec@0 { + compatible = "google,cros-ec-spi"; + reg = <0>; + interrupts = <101 0>; + gpio { + compatible = "google,cros-ec-gpio"; + gpio-controller; + #gpio-cells = <2>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index e1ca4f297c6d..ded396b28fba 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -93,6 +93,9 @@ properties: '#size-cells': const: 0 + gpio: + $ref: /schemas/gpio/google,cros-ec-gpio.yaml# + typec: $ref: /schemas/chrome/google,cros-ec-typec.yaml#
The ChromeOS embedded controller (EC) supports setting the state of GPIOs when the system is unlocked, and getting the state of GPIOs in all cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO expander. Add a binding to describe these GPIOs in DT so that other devices described in DT can read the GPIOs on the EC. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Lee Jones <lee@kernel.org> Cc: Benson Leung <bleung@chromium.org> Cc: Guenter Roeck <groeck@chromium.org> Cc: <linux-gpio@vger.kernel.org> Cc: <devicetree@vger.kernel.org> Cc: <chrome-platform@lists.linux.dev> Cc: Pin-yen Lin <treapking@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- .../bindings/gpio/google,cros-ec-gpio.yaml | 49 +++++++++++++++++++ .../bindings/mfd/google,cros-ec.yaml | 3 ++ 2 files changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/google,cros-ec-gpio.yaml