| Message ID | 20240211094609.2223-5-karelb@gimli.ms.mff.cuni.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | support for Marvell 88PM886 PMIC | expand |
On Sun, Feb 11, 2024 at 10:35:54AM +0100, Karel Balej wrote: > From: Karel Balej <balejk@matfyz.cz> > > Marvell 88PM88X PMICs provide onkey functionality -- add the bindings. > > Signed-off-by: Karel Balej <balejk@matfyz.cz> > --- > > Notes: > RFC v2: > - Add wakeup-source property and reference onkey schema from MFD. > - Reword commit message. > > .../bindings/input/marvell,88pm88x-onkey.yaml | 32 +++++++++++++++++++ > .../bindings/mfd/marvell,88pm88x.yaml | 8 +++++ > 2 files changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > > diff --git a/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > new file mode 100644 > index 000000000000..5d3d451d0e1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/marvell,88pm88x-onkey.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Onkey driver for Marvell 88PM88X PMICs. > + > +maintainers: > + - Karel Balej <balejk@matfyz.cz> > + > +description: | > + This module is part of the 88PM88X MFD device. For more details > + see Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml. > + > + The onkey controller is represented as a sub-node of the PMIC node in > + the device tree. Why do you need a child node? You don't. Just add 'wakeup-source' to the parent. > + > +allOf: > + - $ref: input.yaml# Doesn't look like you are using any properties from this? > + > +properties: > + compatible: > + const: marvell,88pm88x-onkey > + > + wakeup-source: true > + > +required: > + - compatible > + > +additionalProperties: false > +...
diff --git a/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml new file mode 100644 index 000000000000..5d3d451d0e1f --- /dev/null +++ b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/marvell,88pm88x-onkey.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Onkey driver for Marvell 88PM88X PMICs. + +maintainers: + - Karel Balej <balejk@matfyz.cz> + +description: | + This module is part of the 88PM88X MFD device. For more details + see Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml. + + The onkey controller is represented as a sub-node of the PMIC node in + the device tree. + +allOf: + - $ref: input.yaml# + +properties: + compatible: + const: marvell,88pm88x-onkey + + wakeup-source: true + +required: + - compatible + +additionalProperties: false +... diff --git a/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml b/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml index 29ab979862d5..2507a73d4dc3 100644 --- a/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml +++ b/Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml @@ -28,6 +28,9 @@ properties: "#interrupt-cells": const: 1 + onkey: + $ref: /schemas/input/marvell,88pm88x-onkey.yaml + regulators: $ref: /schemas/regulator/marvell,88pm88x-regulator.yaml# @@ -53,6 +56,11 @@ examples: interrupt-controller; #interrupt-cells = <1>; + onkey { + compatible = "marvell,88pm88x-onkey"; + wakeup-source; + }; + regulators { ldo2: ldo2 { regulator-min-microvolt = <3100000>;