| Message ID | 20240215135749.1909812-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sparc: select FRAME_POINTER instead of redefining it | expand |
On 2/15/24 05:57, Masahiro Yamada wrote: > Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig > should select it. > > Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must > also be selected to avoid the unmet dependency warning. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > > arch/sparc/Kconfig.debug | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug > index 37e003665de6..d475a056a2e0 100644 > --- a/arch/sparc/Kconfig.debug > +++ b/arch/sparc/Kconfig.debug > @@ -8,11 +8,8 @@ config MCOUNT > bool > depends on SPARC64 > depends on FUNCTION_TRACER > - default y > - > -config FRAME_POINTER > - bool > - depends on MCOUNT > + select ARCH_WANT_FRAME_POINTERS > + select FRAME_POINTER > default y > > config HAVE_HARDLOCKUP_DETECTOR_SPARC64
On 2024-02-15 14:57, Masahiro Yamada wrote: > Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig > should select it. > > Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must > also be selected to avoid the unmet dependency warning. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Applied to my for-next branch. Thanks, Andreas
diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug index 37e003665de6..d475a056a2e0 100644 --- a/arch/sparc/Kconfig.debug +++ b/arch/sparc/Kconfig.debug @@ -8,11 +8,8 @@ config MCOUNT bool depends on SPARC64 depends on FUNCTION_TRACER - default y - -config FRAME_POINTER - bool - depends on MCOUNT + select ARCH_WANT_FRAME_POINTERS + select FRAME_POINTER default y config HAVE_HARDLOCKUP_DETECTOR_SPARC64
Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig should select it. Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must also be selected to avoid the unmet dependency warning. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/sparc/Kconfig.debug | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)