| Message ID | 20240216-inno-phy-v1-4-1ab912f0533f@outlook.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: hisi-inno-phy: add support for hi3798mv200-usb2-phy | expand |
On 16/02/2024 16:21, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > It is accessed by direct MMIO, making "ranges" property mandatory for > it. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > .../devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml > index 73256eee10f9..d702878b8e6e 100644 > --- a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml > @@ -16,6 +16,7 @@ properties: > - enum: > - hisilicon,hi3798cv200-usb2-phy > - hisilicon,hi3798mv100-usb2-phy > + - hisilicon,hi3798mv200-usb2-phy > - const: hisilicon,inno-usb2-phy > > reg: > @@ -64,6 +65,15 @@ required: > - '#size-cells' > - resets > > +if: allOf: above. > + properties: > + compatible: > + contains: > + const: hisilicon,hi3798mv200-inno-usb2-phy > +then: > + required: > + - ranges So please test your DTS first. > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml index 73256eee10f9..d702878b8e6e 100644 --- a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml @@ -16,6 +16,7 @@ properties: - enum: - hisilicon,hi3798cv200-usb2-phy - hisilicon,hi3798mv100-usb2-phy + - hisilicon,hi3798mv200-usb2-phy - const: hisilicon,inno-usb2-phy reg: @@ -64,6 +65,15 @@ required: - '#size-cells' - resets +if: + properties: + compatible: + contains: + const: hisilicon,hi3798mv200-inno-usb2-phy +then: + required: + - ranges + additionalProperties: false examples: