| Message ID | 20240209070443.3617790-1-iam@sung-woo.kim (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: add missing checks in state transitions | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #97: https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/ total: 0 errors, 1 warnings, 0 checks, 28 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13550940.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 20: B1 Line exceeds max length (96>80): "https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/" |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | fail | TestRunner_mgmt-tester: Total: 492, Passed: 485 (98.6%), Failed: 6, Not Run: 1 |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=824554
---Test result---
Test Summary:
CheckPatch FAIL 0.92 seconds
GitLint FAIL 0.53 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 27.45 seconds
CheckAllWarning PASS 30.10 seconds
CheckSparse PASS 35.81 seconds
CheckSmatch PASS 97.10 seconds
BuildKernel32 PASS 26.71 seconds
TestRunnerSetup PASS 493.02 seconds
TestRunner_l2cap-tester FAIL 12.06 seconds
TestRunner_iso-tester PASS 30.11 seconds
TestRunner_bnep-tester PASS 4.79 seconds
TestRunner_mgmt-tester FAIL 166.38 seconds
TestRunner_rfcomm-tester PASS 7.35 seconds
TestRunner_sco-tester PASS 15.17 seconds
TestRunner_ioctl-tester PASS 7.83 seconds
TestRunner_mesh-tester PASS 5.87 seconds
TestRunner_smp-tester PASS 6.83 seconds
TestRunner_userchan-tester PASS 4.99 seconds
IncrementalBuild PASS 25.70 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: add missing checks in state transitions
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#97:
https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13550940.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: add missing checks in state transitions
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
20: B1 Line exceeds max length (96>80): "https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/"
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
No test result found
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 485 (98.6%), Failed: 6, Not Run: 1
Failed Test Cases
LL Privacy - Add Device 4 (2 Devices to AL) Failed 0.115 seconds
LL Privacy - Add Device 5 (2 Devices to RL) Failed 0.115 seconds
LL Privacy - Add Device 6 (RL is full) Failed 0.142 seconds
LL Privacy - Add Device 7 (AL is full) Failed 0.143 seconds
LL Privacy - Remove Device 2 (Remove from RL) Timed out 2.184 seconds
LL Privacy - Remove Device 4 (Disable Adv) Timed out 1.846 seconds
---
Regards,
Linux Bluetooth
Hello, could I ask for comments on this? On Fri, Feb 9, 2024 at 2:06 AM Sungwoo Kim <iam@sung-woo.kim> wrote: > > When an l2cap channel receives L2CAP_CONN_RSP, it revives from BT_DISCONN > to BT_CONFIG or BT_CONNECTED. > It is very weird, violates the specification, and I cannot see any real > usecase for this. > Similar to this, the L2cap channel has six illegal state transitions: > > 1. BT_CONNECT2 -> BT_CONFIG by L2CAP_CONN_RSP > 2. BT_CONNECT2 -> BT_CONNECTED by L2CAP_CONF_RSP > 3. BT_CONNECT2 -> BT_DISCONN by L2CAP_CONF_RSP > 4. BT_CONNECTED -> BT_CONFIG by L2CAP_CONN_RSP > 5. BT_DISCONN -> BT_CONFIG by L2CAP_CONN_RSP > 6. BT_DISCONN -> BT_CONNECTED by L2CAP_CONN_RSP > > This patch fixes 2, 3, 5, and 6 by adding checks. > For 1 and 4, I will make an RFC for as it requires some refactoring. > > The detaild logs are described in here: > https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/ > > Signed-off-by: Sungwoo Kim <iam@sung-woo.kim> > --- > net/bluetooth/l2cap_core.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 60298975d..c5fa2b683 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -4339,6 +4339,14 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, > > l2cap_chan_lock(chan); > > + switch (chan->state) { > + case BT_CLOSED: > + case BT_DISCONN: > + l2cap_chan_unlock(chan); > + l2cap_chan_put(chan); > + goto unlock; > + } > + > switch (result) { > case L2CAP_CR_SUCCESS: > if (__l2cap_get_chan_by_dcid(conn, dcid)) { > @@ -4552,6 +4560,14 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, > if (!chan) > return 0; > > + switch (chan->state) { > + case BT_CLOSED: > + case BT_CONNECT: > + case BT_CONNECT2: > + case BT_DISCONN: > + goto done; > + } > + > switch (result) { > case L2CAP_CONF_SUCCESS: > l2cap_conf_rfc_get(chan, rsp->data, len); > -- > 2.25.1 >
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 60298975d..c5fa2b683 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4339,6 +4339,14 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, l2cap_chan_lock(chan); + switch (chan->state) { + case BT_CLOSED: + case BT_DISCONN: + l2cap_chan_unlock(chan); + l2cap_chan_put(chan); + goto unlock; + } + switch (result) { case L2CAP_CR_SUCCESS: if (__l2cap_get_chan_by_dcid(conn, dcid)) { @@ -4552,6 +4560,14 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, if (!chan) return 0; + switch (chan->state) { + case BT_CLOSED: + case BT_CONNECT: + case BT_CONNECT2: + case BT_DISCONN: + goto done; + } + switch (result) { case L2CAP_CONF_SUCCESS: l2cap_conf_rfc_get(chan, rsp->data, len);
When an l2cap channel receives L2CAP_CONN_RSP, it revives from BT_DISCONN to BT_CONFIG or BT_CONNECTED. It is very weird, violates the specification, and I cannot see any real usecase for this. Similar to this, the L2cap channel has six illegal state transitions: 1. BT_CONNECT2 -> BT_CONFIG by L2CAP_CONN_RSP 2. BT_CONNECT2 -> BT_CONNECTED by L2CAP_CONF_RSP 3. BT_CONNECT2 -> BT_DISCONN by L2CAP_CONF_RSP 4. BT_CONNECTED -> BT_CONFIG by L2CAP_CONN_RSP 5. BT_DISCONN -> BT_CONFIG by L2CAP_CONN_RSP 6. BT_DISCONN -> BT_CONNECTED by L2CAP_CONN_RSP This patch fixes 2, 3, 5, and 6 by adding checks. For 1 and 4, I will make an RFC for as it requires some refactoring. The detaild logs are described in here: https://lore.kernel.org/lkml/CAJNyHpKpDdps4=QHZ77zu4jfY-NNBcGUrw6UwjuBKfpuSuE__g@mail.gmail.com/ Signed-off-by: Sungwoo Kim <iam@sung-woo.kim> --- net/bluetooth/l2cap_core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)