| Message ID | 20240221-dts-qcom-sm8550-fix-spmi-chnls-size-v2-1-72b5efd9dc4f@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77dd1e50ffcba33c3195ae4fc78f354368ddacb2 |
| Headers | show |
| Series | arm64: dts: qcom: Fix SPMI channels size for SM8550 and SM8650 | expand |
On 21.02.2024 14:04, Abel Vesa wrote: > The actual size of the channels registers region is 4MB, according to the > documentation. This issue was not caught until now because the driver was > supposed to allow same regions being mapped multiple times for supporting > multiple buses. Thie driver is using platform_get_resource_byname() and > devm_ioremap() towards that purpose, which intentionally avoids > devm_request_mem_region() altogether. > > Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi") > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 21/02/2024 14:04, Abel Vesa wrote: > The actual size of the channels registers region is 4MB, according to the > documentation. This issue was not caught until now because the driver was > supposed to allow same regions being mapped multiple times for supporting > multiple buses. Thie driver is using platform_get_resource_byname() and > devm_ioremap() towards that purpose, which intentionally avoids > devm_request_mem_region() altogether. > > Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi") > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 7474cddf7ad3..3904348075f6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -3318,7 +3318,7 @@ sram@c3f0000 { > spmi_bus: spmi@c400000 { > compatible = "qcom,spmi-pmic-arb"; > reg = <0 0x0c400000 0 0x3000>, > - <0 0x0c500000 0 0x4000000>, > + <0 0x0c500000 0 0x400000>, > <0 0x0c440000 0 0x80000>, > <0 0x0c4c0000 0 0x20000>, > <0 0x0c42d000 0 0x4000>; > Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 7474cddf7ad3..3904348075f6 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -3318,7 +3318,7 @@ sram@c3f0000 { spmi_bus: spmi@c400000 { compatible = "qcom,spmi-pmic-arb"; reg = <0 0x0c400000 0 0x3000>, - <0 0x0c500000 0 0x4000000>, + <0 0x0c500000 0 0x400000>, <0 0x0c440000 0 0x80000>, <0 0x0c4c0000 0 0x20000>, <0 0x0c42d000 0 0x4000>;
The actual size of the channels registers region is 4MB, according to the documentation. This issue was not caught until now because the driver was supposed to allow same regions being mapped multiple times for supporting multiple buses. Thie driver is using platform_get_resource_byname() and devm_ioremap() towards that purpose, which intentionally avoids devm_request_mem_region() altogether. Fixes: ffc50b2d3828 ("arm64: dts: qcom: Add base SM8550 dtsi") Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)