| Message ID | 3b267fb1b303f63248934a1a77bee319e1c44879.1708458882.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | power: reset: rmobile-reset: Map correct MMIO resource | expand |
On 2/20/24 1:55 PM, Geert Uytterhoeven wrote: > The registers related to reset generation are located in the second > register block. However, the conversion to device life-cycle managed > ioremap function accidentally changed the mapping to the first register > block. > > Fixes: 0867276eb12230a5 ("power: reset: rmobile-reset: Use devm_platform_ioremap_resource() helper") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- Acked-by: Andrew Davis <afd@ti.com> > drivers/power/reset/rmobile-reset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/rmobile-reset.c b/drivers/power/reset/rmobile-reset.c > index 80265608c18e0a20..14682cd59e618d5f 100644 > --- a/drivers/power/reset/rmobile-reset.c > +++ b/drivers/power/reset/rmobile-reset.c > @@ -33,7 +33,7 @@ static int rmobile_reset_probe(struct platform_device *pdev) > { > int error; > > - sysc_base2 = devm_platform_ioremap_resource(pdev, 0); > + sysc_base2 = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(sysc_base2)) > return PTR_ERR(sysc_base2); >
On Tue, 20 Feb 2024 20:55:53 +0100, Geert Uytterhoeven wrote: > The registers related to reset generation are located in the second > register block. However, the conversion to device life-cycle managed > ioremap function accidentally changed the mapping to the first register > block. > > Applied, thanks! [1/1] power: reset: rmobile-reset: Map correct MMIO resource commit: 6f005ab7f5814bcbb58154167c282f03fc35db6a Best regards,
diff --git a/drivers/power/reset/rmobile-reset.c b/drivers/power/reset/rmobile-reset.c index 80265608c18e0a20..14682cd59e618d5f 100644 --- a/drivers/power/reset/rmobile-reset.c +++ b/drivers/power/reset/rmobile-reset.c @@ -33,7 +33,7 @@ static int rmobile_reset_probe(struct platform_device *pdev) { int error; - sysc_base2 = devm_platform_ioremap_resource(pdev, 0); + sysc_base2 = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(sysc_base2)) return PTR_ERR(sysc_base2);
The registers related to reset generation are located in the second register block. However, the conversion to device life-cycle managed ioremap function accidentally changed the mapping to the first register block. Fixes: 0867276eb12230a5 ("power: reset: rmobile-reset: Use devm_platform_ioremap_resource() helper") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/power/reset/rmobile-reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)