| Message ID | 20240221133346.3295639-1-kiran.k@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 452481b004a5707842457c3f2e848d362e74667e |
| Headers | show |
| Series | [v2] Bluetooth: btintel: Print Firmware Sequencer information | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 21 Feb 2024 19:03:46 +0530 you wrote: > Firmware sequencer (FSEQ) is a common code shared across Bluetooth > and Wifi. Printing FSEQ will help to debug if there is any mismatch > between Bluetooth and Wifi FSEQ. > > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 114 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 114 insertions(+) > > [...] Here is the summary with links: - [v2] Bluetooth: btintel: Print Firmware Sequencer information https://git.kernel.org/bluetooth/bluetooth-next/c/452481b004a5 You are awesome, thank you!
Dear Kiran, Thank you for incorperating the feedback. Am 21.02.24 um 14:33 schrieb Kiran K: > Firmware sequencer (FSEQ) is a common code shared across Bluetooth > and Wifi. Printing FSEQ will help to debug if there is any mismatch > between Bluetooth and Wifi FSEQ. > > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 114 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 114 insertions(+) > > Kernel log snippet: > > [ 3.643765] Bluetooth: hci0: Fseq status: Success (0x00) > [ 3.643769] Bluetooth: hci0: Fseq executed: 00.00.02.41 > [ 3.643771] Bluetooth: hci0: Fseq BT Top: 00.00.02.41 Next time I think this could go into the proper commit message. > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > index e5b043d96207..a083c4b8621c 100644 > --- a/drivers/bluetooth/btintel.c > +++ b/drivers/bluetooth/btintel.c > @@ -2670,6 +2670,119 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) > } > } > > +static void btintel_print_fseq_info(struct hci_dev *hdev) > +{ > + struct sk_buff *skb; > + u8 *p; > + u32 val; > + const char *str; > + > + skb = __hci_cmd_sync(hdev, 0xfcb3, 0, NULL, HCI_CMD_TIMEOUT); > + if (IS_ERR(skb)) { > + bt_dev_dbg(hdev, "Reading fseq status command failed (%ld)", > + PTR_ERR(skb)); > + return; > + } > + > + if (skb->len < (sizeof(u32) * 16 + 2)) { > + bt_dev_dbg(hdev, "Malformed packet of length %u received", > + skb->len); I would have also printed the value of `sizeof(u32) * 16 + 2`: bt_dev_dbg(hdev, "Malformed packet of length %u received: too short < %u", skb->len, sizeof(u32) * 16 + 2) Kind regards, Paul > + kfree_skb(skb); > + return; > + } > + > + p = skb_pull_data(skb, 1); > + if (*p) { > + bt_dev_dbg(hdev, "Failed to get fseq status (0x%2.2x)", *p); > + kfree_skb(skb); > + return; > + } > + > + p = skb_pull_data(skb, 1); > + switch (*p) { > + case 0: > + str = "Success"; > + break; > + case 1: > + str = "Fatal error"; > + break; > + case 2: > + str = "Semaphore acquire error"; > + break; > + default: > + str = "Unknown error"; > + break; > + } > + > + if (*p) { > + bt_dev_err(hdev, "Fseq status: %s (0x%2.2x)", str, *p); > + kfree_skb(skb); > + return; > + } > + > + bt_dev_info(hdev, "Fseq status: %s (0x%2.2x)", str, *p); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Reason: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Global version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Installed version: 0x%8.8x", val); > + > + p = skb->data; > + skb_pull_data(skb, 4); > + bt_dev_info(hdev, "Fseq executed: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1], > + p[2], p[3]); > + > + p = skb->data; > + skb_pull_data(skb, 4); > + bt_dev_info(hdev, "Fseq BT Top: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1], > + p[2], p[3]); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq Top init version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq Cnvio init version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq MBX Wifi file version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq BT version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq Top reset address: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq MBX timeout: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq MBX ack: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq CNVi id: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq CNVr id: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq Error handle: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq Magic noalive indication: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq OTP version: 0x%8.8x", val); > + > + val = get_unaligned_le32(skb_pull_data(skb, 4)); > + bt_dev_dbg(hdev, "Fseq MBX otp version: 0x%8.8x", val); > + > + kfree_skb(skb); > +} > + > static int btintel_setup_combined(struct hci_dev *hdev) > { > const u8 param[1] = { 0xFF }; > @@ -2902,6 +3015,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) > > err = btintel_bootloader_setup_tlv(hdev, &ver_tlv); > btintel_register_devcoredump_support(hdev); > + btintel_print_fseq_info(hdev); > break; > default: > bt_dev_err(hdev, "Unsupported Intel hw variant (%u)",
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index e5b043d96207..a083c4b8621c 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -2670,6 +2670,119 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) } } +static void btintel_print_fseq_info(struct hci_dev *hdev) +{ + struct sk_buff *skb; + u8 *p; + u32 val; + const char *str; + + skb = __hci_cmd_sync(hdev, 0xfcb3, 0, NULL, HCI_CMD_TIMEOUT); + if (IS_ERR(skb)) { + bt_dev_dbg(hdev, "Reading fseq status command failed (%ld)", + PTR_ERR(skb)); + return; + } + + if (skb->len < (sizeof(u32) * 16 + 2)) { + bt_dev_dbg(hdev, "Malformed packet of length %u received", + skb->len); + kfree_skb(skb); + return; + } + + p = skb_pull_data(skb, 1); + if (*p) { + bt_dev_dbg(hdev, "Failed to get fseq status (0x%2.2x)", *p); + kfree_skb(skb); + return; + } + + p = skb_pull_data(skb, 1); + switch (*p) { + case 0: + str = "Success"; + break; + case 1: + str = "Fatal error"; + break; + case 2: + str = "Semaphore acquire error"; + break; + default: + str = "Unknown error"; + break; + } + + if (*p) { + bt_dev_err(hdev, "Fseq status: %s (0x%2.2x)", str, *p); + kfree_skb(skb); + return; + } + + bt_dev_info(hdev, "Fseq status: %s (0x%2.2x)", str, *p); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Reason: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Global version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Installed version: 0x%8.8x", val); + + p = skb->data; + skb_pull_data(skb, 4); + bt_dev_info(hdev, "Fseq executed: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1], + p[2], p[3]); + + p = skb->data; + skb_pull_data(skb, 4); + bt_dev_info(hdev, "Fseq BT Top: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1], + p[2], p[3]); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq Top init version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq Cnvio init version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq MBX Wifi file version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq BT version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq Top reset address: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq MBX timeout: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq MBX ack: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq CNVi id: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq CNVr id: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq Error handle: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq Magic noalive indication: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq OTP version: 0x%8.8x", val); + + val = get_unaligned_le32(skb_pull_data(skb, 4)); + bt_dev_dbg(hdev, "Fseq MBX otp version: 0x%8.8x", val); + + kfree_skb(skb); +} + static int btintel_setup_combined(struct hci_dev *hdev) { const u8 param[1] = { 0xFF }; @@ -2902,6 +3015,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) err = btintel_bootloader_setup_tlv(hdev, &ver_tlv); btintel_register_devcoredump_support(hdev); + btintel_print_fseq_info(hdev); break; default: bt_dev_err(hdev, "Unsupported Intel hw variant (%u)",
Firmware sequencer (FSEQ) is a common code shared across Bluetooth and Wifi. Printing FSEQ will help to debug if there is any mismatch between Bluetooth and Wifi FSEQ. Signed-off-by: Kiran K <kiran.k@intel.com> --- drivers/bluetooth/btintel.c | 114 ++++++++++++++++++++++++++++++++++++ 1 file changed, 114 insertions(+) Kernel log snippet: [ 3.643765] Bluetooth: hci0: Fseq status: Success (0x00) [ 3.643769] Bluetooth: hci0: Fseq executed: 00.00.02.41 [ 3.643771] Bluetooth: hci0: Fseq BT Top: 00.00.02.41