| Message ID | 20240220-stmmac_est-v1-1-c41f9ae2e7b7@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 90d07e36d40079a22ca99edd2412e7e9c2382968 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: stmmac: Fix EST offset for dwmac 5.10 | expand |
Hi Kurt On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote: > Fix EST offset for dwmac 5.10. > > Currently configuring Qbv doesn't work as expected. The schedule is > configured, but never confirmed: > > |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST > > The reason seems to be the refactoring of the EST code which set the wrong > EST offset for the dwmac 5.10. After fixing this it works as before: > > |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST > |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched > > Tested on imx93. > > Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > --- > drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c > index 1bd34b2a47e8..29367105df54 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c > +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c > @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry { > .regs = { > .ptp_off = PTP_GMAC4_OFFSET, > .mmc_off = MMC_GMAC4_OFFSET, > - .est_off = EST_XGMAC_OFFSET, > + .est_off = EST_GMAC4_OFFSET, Unfortunate c&p typo indeed. Thanks for fixing it! Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > }, > .desc = &dwmac4_desc_ops, > .dma = &dwmac410_dma_ops, > > --- > base-commit: 40b9385dd8e6a0515e1c9cd06a277483556b7286 > change-id: 20240220-stmmac_est-ea6884f9ba3c > > Best regards, > -- > Kurt Kanzenbach <kurt@linutronix.de> > >
On Tue Feb 20 2024, Serge Semin wrote: > Hi Kurt > > On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote: >> Fix EST offset for dwmac 5.10. >> >> Currently configuring Qbv doesn't work as expected. The schedule is >> configured, but never confirmed: >> >> |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST >> >> The reason seems to be the refactoring of the EST code which set the wrong >> EST offset for the dwmac 5.10. After fixing this it works as before: >> >> |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST >> |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched >> >> Tested on imx93. >> >> Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") >> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> >> --- >> drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c >> index 1bd34b2a47e8..29367105df54 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c >> @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry { >> .regs = { >> .ptp_off = PTP_GMAC4_OFFSET, >> .mmc_off = MMC_GMAC4_OFFSET, >> - .est_off = EST_XGMAC_OFFSET, >> + .est_off = EST_GMAC4_OFFSET, > > Unfortunate c&p typo indeed. Thanks for fixing it! No problem. I was just wondering why the confirmation message doesn't show up after updating to v6.8-RT :-). Thanks, Kurt
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 20 Feb 2024 09:22:46 +0100 you wrote: > Fix EST offset for dwmac 5.10. > > Currently configuring Qbv doesn't work as expected. The schedule is > configured, but never confirmed: > > |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST > > [...] Here is the summary with links: - [net] net: stmmac: Fix EST offset for dwmac 5.10 https://git.kernel.org/netdev/net/c/90d07e36d400 You are awesome, thank you!
Hi Kurt, On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote: > Fix EST offset for dwmac 5.10. > > Currently configuring Qbv doesn't work as expected. The schedule is > configured, but never confirmed: > > |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST > > The reason seems to be the refactoring of the EST code which set the wrong > EST offset for the dwmac 5.10. After fixing this it works as before: > > |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST [ > |128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been > |switched > > Tested on imx93. > > Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > --- Thanks for fixing this. Sorry for the typo. Best Regards, Rohan
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c index 1bd34b2a47e8..29367105df54 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry { .regs = { .ptp_off = PTP_GMAC4_OFFSET, .mmc_off = MMC_GMAC4_OFFSET, - .est_off = EST_XGMAC_OFFSET, + .est_off = EST_GMAC4_OFFSET, }, .desc = &dwmac4_desc_ops, .dma = &dwmac410_dma_ops,
Fix EST offset for dwmac 5.10. Currently configuring Qbv doesn't work as expected. The schedule is configured, but never confirmed: |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST The reason seems to be the refactoring of the EST code which set the wrong EST offset for the dwmac 5.10. After fixing this it works as before: |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched Tested on imx93. Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation") Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 40b9385dd8e6a0515e1c9cd06a277483556b7286 change-id: 20240220-stmmac_est-ea6884f9ba3c Best regards,