| Message ID | 20240221111901.2807853-1-joakim.tjernlund@infinera.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bluez.pc.in: Add definition of libexecdir | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=828228 ---Test result--- Test Summary: CheckPatch PASS 0.45 seconds GitLint PASS 0.34 seconds BuildEll PASS 24.09 seconds BluezMake PASS 731.39 seconds MakeCheck PASS 11.64 seconds MakeDistcheck PASS 164.21 seconds CheckValgrind PASS 226.26 seconds CheckSmatch PASS 332.91 seconds bluezmakeextell PASS 107.54 seconds IncrementalBuild PASS 689.97 seconds ScanBuild PASS 971.58 seconds --- Regards, Linux Bluetooth
On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund <joakim.tjernlund@infinera.com> wrote: > > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > --- > lib/bluez.pc.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in > index 3d6e59616..1c2f30b33 100644 > --- a/lib/bluez.pc.in > +++ b/lib/bluez.pc.in > @@ -1,6 +1,7 @@ > prefix=@prefix@ > exec_prefix=@exec_prefix@ > libdir=@libdir@ > +libexecdir=@libexecdir@ > includedir=@includedir@ > It seems to be unused in the pkg-config file. Why do we need this? -Emil
On Thu, 2024-02-22 at 12:54 +0000, Emil Velikov wrote: > On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund > <joakim.tjernlund@infinera.com> wrote: > > > > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > --- > > lib/bluez.pc.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in > > index 3d6e59616..1c2f30b33 100644 > > --- a/lib/bluez.pc.in > > +++ b/lib/bluez.pc.in > > @@ -1,6 +1,7 @@ > > prefix=@prefix@ > > exec_prefix=@exec_prefix@ > > libdir=@libdir@ > > +libexecdir=@libexecdir@ > > includedir=@includedir@ > > > > It seems to be unused in the pkg-config file. Why do we need this? > > Bluez does not but pkg-config is for other apps so if some app needs to know something about bluez stuff living in libexecdir it can find out where that is. Jocke
On Thu, 22 Feb 2024 at 13:10, Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote: > > On Thu, 2024-02-22 at 12:54 +0000, Emil Velikov wrote: > > On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund > > <joakim.tjernlund@infinera.com> wrote: > > > > > > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > --- > > > lib/bluez.pc.in | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in > > > index 3d6e59616..1c2f30b33 100644 > > > --- a/lib/bluez.pc.in > > > +++ b/lib/bluez.pc.in > > > @@ -1,6 +1,7 @@ > > > prefix=@prefix@ > > > exec_prefix=@exec_prefix@ > > > libdir=@libdir@ > > > +libexecdir=@libexecdir@ > > > includedir=@includedir@ > > > > > > > It seems to be unused in the pkg-config file. Why do we need this? > > > > > > Bluez does not but pkg-config is for other apps so if some app needs to know > something about bluez stuff living in libexecdir it can find out where that is. > "_some_ app needs to know _something_" sounds like the key here (emphasis mine). Do you have an example? Is the (bluetoothd/obexd) daemon location of interest, the cups backend, other? Thanks Emil
On Fri, 2024-02-23 at 11:14 +0000, Emil Velikov wrote: > On Thu, 22 Feb 2024 at 13:10, Joakim Tjernlund > <Joakim.Tjernlund@infinera.com> wrote: > > > > On Thu, 2024-02-22 at 12:54 +0000, Emil Velikov wrote: > > > On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund > > > <joakim.tjernlund@infinera.com> wrote: > > > > > > > > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > --- > > > > lib/bluez.pc.in | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in > > > > index 3d6e59616..1c2f30b33 100644 > > > > --- a/lib/bluez.pc.in > > > > +++ b/lib/bluez.pc.in > > > > @@ -1,6 +1,7 @@ > > > > prefix=@prefix@ > > > > exec_prefix=@exec_prefix@ > > > > libdir=@libdir@ > > > > +libexecdir=@libexecdir@ > > > > includedir=@includedir@ > > > > > > > > > > It seems to be unused in the pkg-config file. Why do we need this? > > > > > > > > > > Bluez does not but pkg-config is for other apps so if some app needs to know > > something about bluez stuff living in libexecdir it can find out where that is. > > > > "_some_ app needs to know _something_" sounds like the key here (emphasis mine). > > Do you have an example? Is the (bluetoothd/obexd) daemon location of > interest, the cups backend, other? No example. I just think it is proper form to publish this info. Jocke
On Fri, 23 Feb 2024 at 12:09, Joakim Tjernlund <Joakim.Tjernlund@infinera.com> wrote: > > On Fri, 2024-02-23 at 11:14 +0000, Emil Velikov wrote: > > On Thu, 22 Feb 2024 at 13:10, Joakim Tjernlund > > <Joakim.Tjernlund@infinera.com> wrote: > > > > > > On Thu, 2024-02-22 at 12:54 +0000, Emil Velikov wrote: > > > > On Wed, 21 Feb 2024 at 11:19, Joakim Tjernlund > > > > <joakim.tjernlund@infinera.com> wrote: > > > > > > > > > > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > > > > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > > > > --- > > > > > lib/bluez.pc.in | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in > > > > > index 3d6e59616..1c2f30b33 100644 > > > > > --- a/lib/bluez.pc.in > > > > > +++ b/lib/bluez.pc.in > > > > > @@ -1,6 +1,7 @@ > > > > > prefix=@prefix@ > > > > > exec_prefix=@exec_prefix@ > > > > > libdir=@libdir@ > > > > > +libexecdir=@libexecdir@ > > > > > includedir=@includedir@ > > > > > > > > > > > > > It seems to be unused in the pkg-config file. Why do we need this? > > > > > > > > > > > > > > Bluez does not but pkg-config is for other apps so if some app needs to know > > > something about bluez stuff living in libexecdir it can find out where that is. > > > > > > > "_some_ app needs to know _something_" sounds like the key here (emphasis mine). > > > > Do you have an example? Is the (bluetoothd/obexd) daemon location of > > interest, the cups backend, other? > > No example. I just think it is proper form to publish this info. > Looking through my system, literally every project apart from one defines _and_ uses libexecdir. The only exception being Qt6. Skimming through the pkg-config documentation I cannot see any mentions, so it seems to be that this isn't the proper way. -Emil
diff --git a/lib/bluez.pc.in b/lib/bluez.pc.in index 3d6e59616..1c2f30b33 100644 --- a/lib/bluez.pc.in +++ b/lib/bluez.pc.in @@ -1,6 +1,7 @@ prefix=@prefix@ exec_prefix=@exec_prefix@ libdir=@libdir@ +libexecdir=@libexecdir@ includedir=@includedir@ Name: BlueZ