| Message ID | 20240222-gunyah-v17-5-1e9da6763d38@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Drivers for Gunyah hypervisor | expand |
On 23.02.2024 00:16, Elliot Berman wrote: > Add driver to detect when running under Gunyah. It performs basic > identification hypercall and populates the platform bus for resource > manager to probe. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- [...] > + > + /* Might move this out to individual drivers if there's ever an API version bump */ > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { > + pr_info("Unsupported Gunyah version: %u\n", > + gunyah_api_version(&gunyah_api)); Weird for this not to be an error, but it's probably not worth resending over if it's the only thing Konrad
On Fri, Feb 23, 2024 at 10:10:47PM +0100, Konrad Dybcio wrote: > On 23.02.2024 00:16, Elliot Berman wrote: > > Add driver to detect when running under Gunyah. It performs basic > > identification hypercall and populates the platform bus for resource > > manager to probe. > > > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > > --- > > [...] > > > + > > + /* Might move this out to individual drivers if there's ever an API version bump */ > > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { > > + pr_info("Unsupported Gunyah version: %u\n", > > + gunyah_api_version(&gunyah_api)); > > Weird for this not to be an error, but it's probably not worth resending > over if it's the only thing It is an error, but maybe I misunderstood: > > + /* Might move this out to individual drivers if there's ever an API version bump */ > > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { > > + pr_info("Unsupported Gunyah version: %u\n", > > + gunyah_api_version(&gunyah_api)); > > + return -ENODEV; > > + }
On 23.02.2024 23:58, Elliot Berman wrote: > On Fri, Feb 23, 2024 at 10:10:47PM +0100, Konrad Dybcio wrote: >> On 23.02.2024 00:16, Elliot Berman wrote: >>> Add driver to detect when running under Gunyah. It performs basic >>> identification hypercall and populates the platform bus for resource >>> manager to probe. >>> >>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> >>> --- >> >> [...] >> >>> + >>> + /* Might move this out to individual drivers if there's ever an API version bump */ >>> + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { >>> + pr_info("Unsupported Gunyah version: %u\n", >>> + gunyah_api_version(&gunyah_api)); >> >> Weird for this not to be an error, but it's probably not worth resending >> over if it's the only thing > > It is an error, but maybe I misunderstood: Sorry, I meant "pr_info might have been pr_err" Konrad > >>> + /* Might move this out to individual drivers if there's ever an API version bump */ >>> + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { >>> + pr_info("Unsupported Gunyah version: %u\n", >>> + gunyah_api_version(&gunyah_api)); >>> + return -ENODEV; >>> + } >
* Elliot Berman <quic_eberman@quicinc.com> [2024-02-22 15:16:28]: > Add driver to detect when running under Gunyah. It performs basic > identification hypercall and populates the platform bus for resource > manager to probe. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> LGTM Reviewed-by: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> - vatsa
diff --git a/drivers/virt/Makefile b/drivers/virt/Makefile index f29901bd78205..ef6a3835d078c 100644 --- a/drivers/virt/Makefile +++ b/drivers/virt/Makefile @@ -10,3 +10,4 @@ obj-y += vboxguest/ obj-$(CONFIG_NITRO_ENCLAVES) += nitro_enclaves/ obj-$(CONFIG_ACRN_HSM) += acrn/ obj-y += coco/ +obj-y += gunyah/ diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile new file mode 100644 index 0000000000000..34f32110faf9a --- /dev/null +++ b/drivers/virt/gunyah/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-$(CONFIG_GUNYAH) += gunyah.o diff --git a/drivers/virt/gunyah/gunyah.c b/drivers/virt/gunyah/gunyah.c new file mode 100644 index 0000000000000..ef8a85f275905 --- /dev/null +++ b/drivers/virt/gunyah/gunyah.c @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. + */ + +#include <linux/gunyah.h> +#include <linux/module.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> + +static int gunyah_probe(struct platform_device *pdev) +{ + struct gunyah_hypercall_hyp_identify_resp gunyah_api; + + if (!arch_is_gunyah_guest()) + return -ENODEV; + + gunyah_hypercall_hyp_identify(&gunyah_api); + + pr_info("Running under Gunyah hypervisor %llx/v%u\n", + FIELD_GET(GUNYAH_API_INFO_VARIANT_MASK, gunyah_api.api_info), + gunyah_api_version(&gunyah_api)); + + /* Might move this out to individual drivers if there's ever an API version bump */ + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) { + pr_info("Unsupported Gunyah version: %u\n", + gunyah_api_version(&gunyah_api)); + return -ENODEV; + } + + return devm_of_platform_populate(&pdev->dev); +} + +static const struct of_device_id gunyah_of_match[] = { + { .compatible = "gunyah-hypervisor" }, + {} +}; +MODULE_DEVICE_TABLE(of, gunyah_of_match); + +/* clang-format off */ +static struct platform_driver gunyah_driver = { + .probe = gunyah_probe, + .driver = { + .name = "gunyah", + .of_match_table = gunyah_of_match, + } +}; +/* clang-format on */ +module_platform_driver(gunyah_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Gunyah Driver");
Add driver to detect when running under Gunyah. It performs basic identification hypercall and populates the platform bus for resource manager to probe. Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> --- drivers/virt/Makefile | 1 + drivers/virt/gunyah/Makefile | 3 +++ drivers/virt/gunyah/gunyah.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+)