| Message ID | 20240221211204.515159-1-david.e.box@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/3] platform/x86/intel/vsec: Remove nuisance message | expand |
On 2/21/24 1:12 PM, David E. Box wrote: > intel_vsec_walk_header() is used to configure features from devices that > don't provide a PCI VSEC or DVSEC structure. Some of these features may > be unsupported and fail to load. Ignore them silently as we do for > unsupported features described by VSEC/DVSEC. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- Change looks fine to me. Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/intel/vsec.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c > index 778eb0aa3479..0fdfaf3a4f5c 100644 > --- a/drivers/platform/x86/intel/vsec.c > +++ b/drivers/platform/x86/intel/vsec.c > @@ -236,10 +236,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, > > for ( ; *header; header++) { > ret = intel_vsec_add_dev(pdev, *header, info); > - if (ret) > - dev_info(&pdev->dev, "Could not add device for VSEC id %d\n", > - (*header)->id); > - else > + if (!ret) > have_devices = true; > } > > > base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de
On Wed, 21 Feb 2024, David E. Box wrote: > intel_vsec_walk_header() is used to configure features from devices that > don't provide a PCI VSEC or DVSEC structure. Some of these features may > be unsupported and fail to load. Ignore them silently as we do for > unsupported features described by VSEC/DVSEC. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > drivers/platform/x86/intel/vsec.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c > index 778eb0aa3479..0fdfaf3a4f5c 100644 > --- a/drivers/platform/x86/intel/vsec.c > +++ b/drivers/platform/x86/intel/vsec.c > @@ -236,10 +236,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, > > for ( ; *header; header++) { > ret = intel_vsec_add_dev(pdev, *header, info); > - if (ret) > - dev_info(&pdev->dev, "Could not add device for VSEC id %d\n", > - (*header)->id); > - else > + if (!ret) > have_devices = true; > } Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c index 778eb0aa3479..0fdfaf3a4f5c 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -236,10 +236,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, for ( ; *header; header++) { ret = intel_vsec_add_dev(pdev, *header, info); - if (ret) - dev_info(&pdev->dev, "Could not add device for VSEC id %d\n", - (*header)->id); - else + if (!ret) have_devices = true; }
intel_vsec_walk_header() is used to configure features from devices that don't provide a PCI VSEC or DVSEC structure. Some of these features may be unsupported and fail to load. Ignore them silently as we do for unsupported features described by VSEC/DVSEC. Signed-off-by: David E. Box <david.e.box@linux.intel.com> --- drivers/platform/x86/intel/vsec.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de