| Message ID | 20240221211204.515159-3-david.e.box@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/3] platform/x86/intel/vsec: Remove nuisance message | expand |
On 2/21/24 1:12 PM, David E. Box wrote: > To unblock Package C state entry, put the GNA device in D3 by default if no > driver is loaded for it. Can you add more details about the C state issue? If no driver is enumerated, should it not follow the firmware default value? Why not fix this in firmware? > > Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver") > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > drivers/platform/x86/intel/pmc/arl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c > index 683ae828276b..34b4cd23bfe5 100644 > --- a/drivers/platform/x86/intel/pmc/arl.c > +++ b/drivers/platform/x86/intel/pmc/arl.c > @@ -673,6 +673,7 @@ static struct pmc_info arl_pmc_info_list[] = { > }; > > #define ARL_NPU_PCI_DEV 0xad1d > +#define ARL_GNA_PCI_DEV 0xae4c > /* > * Set power state of select devices that do not have drivers to D3 > * so that they do not block Package C entry. > @@ -680,6 +681,7 @@ static struct pmc_info arl_pmc_info_list[] = { > static void arl_d3_fixup(void) > { > pmc_core_set_device_d3(ARL_NPU_PCI_DEV); > + pmc_core_set_device_d3(ARL_GNA_PCI_DEV); > } > > static int arl_resume(struct pmc_dev *pmcdev)
On Wed, 21 Feb 2024, David E. Box wrote: > To unblock Package C state entry, put the GNA device in D3 by default if no Hi David, It would be nice if this kind of not so well-known acronyms are opened by default in the commit message so reviewers have a chance to understand what this is about (me included, I had to look it up). Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c index 683ae828276b..34b4cd23bfe5 100644 --- a/drivers/platform/x86/intel/pmc/arl.c +++ b/drivers/platform/x86/intel/pmc/arl.c @@ -673,6 +673,7 @@ static struct pmc_info arl_pmc_info_list[] = { }; #define ARL_NPU_PCI_DEV 0xad1d +#define ARL_GNA_PCI_DEV 0xae4c /* * Set power state of select devices that do not have drivers to D3 * so that they do not block Package C entry. @@ -680,6 +681,7 @@ static struct pmc_info arl_pmc_info_list[] = { static void arl_d3_fixup(void) { pmc_core_set_device_d3(ARL_NPU_PCI_DEV); + pmc_core_set_device_d3(ARL_GNA_PCI_DEV); } static int arl_resume(struct pmc_dev *pmcdev)
To unblock Package C state entry, put the GNA device in D3 by default if no driver is loaded for it. Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver") Signed-off-by: David E. Box <david.e.box@linux.intel.com> --- drivers/platform/x86/intel/pmc/arl.c | 2 ++ 1 file changed, 2 insertions(+)