[net-next,resend,0/6] Support for ASP 2.2 and optimizations

Message

Justin Chen Feb. 23, 2024, 10:24 p.m. UTC

ASP 2.2 adds some power savings during low power modes.

Also make various improvements when entering low power modes and
reduce MDIO traffic by hooking up interrupts.

Justin Chen (6):
  dt-bindings: net: brcm,unimac-mdio: Add asp-v2.2
  dt-bindings: net: brcm,asp-v2.0: Add asp-v2.2
  net: bcmasp: Add support for ASP 2.2
  net: phy: mdio-bcm-unimac: Add asp v2.2 support
  net: bcmasp: Keep buffers through power management
  net: bcmasp: Add support for PHY interrupts

 .../bindings/net/brcm,asp-v2.0.yaml           |   4 +
 .../bindings/net/brcm,unimac-mdio.yaml        |   1 +
 drivers/net/ethernet/broadcom/asp2/bcmasp.c   |  90 +++++++-
 drivers/net/ethernet/broadcom/asp2/bcmasp.h   |  23 ++-
 .../net/ethernet/broadcom/asp2/bcmasp_intf.c  | 192 ++++++++----------
 drivers/net/mdio/mdio-bcm-unimac.c            |   1 +
 6 files changed, 195 insertions(+), 116 deletions(-)

Comments

Krzysztof Kozlowski Feb. 24, 2024, 10:23 a.m. UTC | #1

On 23/02/2024 23:24, Justin Chen wrote:
> ASP 2.2 adds some power savings during low power modes.
> 
> Also make various improvements when entering low power modes and
> reduce MDIO traffic by hooking up interrupts.

Why are you resending?

Why did you ignore tags/feedback?

Best regards,
Krzysztof

Justin Chen Feb. 26, 2024, 7:46 p.m. UTC | #2

On 2/24/24 2:23 AM, Krzysztof Kozlowski wrote:
> On 23/02/2024 23:24, Justin Chen wrote:
>> ASP 2.2 adds some power savings during low power modes.
>>
>> Also make various improvements when entering low power modes and
>> reduce MDIO traffic by hooking up interrupts.
> 
> Why are you resending?
> 
> Why did you ignore tags/feedback?
> 

I think I misunderstood the resend tag. The feedback was I needed to 
rebase onto a newer net-next to resolve a merge conflict. I addressed 
this feedback, but this should have been v2 and not resend. Apologies. 
Totally forgot about Florian's tags. Will send a v2 after we resolve the 
current comments with the device tree.

Thanks,
Justin


> Best regards,
> Krzysztof
>