diff mbox series

[1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt

Message ID 20240226130826.3824251-1-peng.fan@oss.nxp.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt | expand

Commit Message

Peng Fan (OSS) Feb. 26, 2024, 1:08 p.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
so drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Conor Dooley Feb. 26, 2024, 4:24 p.m. UTC | #1 
On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.

Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.

Thanks,
Conor.

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
>        - description: normal conversion, include EOC (End of Conversion),
>            ECH (End of Chain), JEOC (End of Injected Conversion) and
>            JECH (End of injected Chain).
> -      - description: Self-testing Interrupts.
>  
>    clocks:
>      maxItems: 1
> @@ -70,8 +69,7 @@ examples:
>              reg = <0x44530000 0x10000>;
>              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
>              clocks = <&clk IMX93_CLK_ADC1_GATE>;
>              clock-names = "ipg";
>              vref-supply = <&reg_vref_1v8>;
> -- 
> 2.37.1
>
Jonathan Cameron Feb. 26, 2024, 7:20 p.m. UTC | #2 
On Mon, 26 Feb 2024 16:24:47 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > so drop it.  
> 
> Don't just remove it from the example, drop it from the binding too?
> It does permit a 4th "self testing" interrupt.

I'm missing something. See below...
> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > index dacc526dc695..dfc3f512918f 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > @@ -31,7 +31,6 @@ properties:
> >        - description: normal conversion, include EOC (End of Conversion),
> >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> >            JECH (End of injected Chain).
> > -      - description: Self-testing Interrupts.

Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

> >  
> >    clocks:
> >      maxItems: 1
> > @@ -70,8 +69,7 @@ examples:
> >              reg = <0x44530000 0x10000>;
> >              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> >                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> > +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> >              clocks = <&clk IMX93_CLK_ADC1_GATE>;
> >              clock-names = "ipg";
> >              vref-supply = <&reg_vref_1v8>;
> > -- 
> > 2.37.1
> >
Conor Dooley Feb. 26, 2024, 9:17 p.m. UTC | #3 
On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > > 
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > so drop it.  
> > 
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
> 
> I'm missing something. See below...
> > 
> > Thanks,
> > Conor.
> > 
> > > 
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > >        - description: normal conversion, include EOC (End of Conversion),
> > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > >            JECH (End of injected Chain).
> > > -      - description: Self-testing Interrupts.
> 
> Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Jonathan Cameron Feb. 26, 2024, 10:06 p.m. UTC | #4 
On Mon, 26 Feb 2024 21:17:06 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> > On Mon, 26 Feb 2024 16:24:47 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >   
> > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:  
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > > 
> > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > > so drop it.    
> > > 
> > > Don't just remove it from the example, drop it from the binding too?
> > > It does permit a 4th "self testing" interrupt.  
> > 
> > I'm missing something. See below...  
> > > 
> > > Thanks,
> > > Conor.
> > >   
> > > > 
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > index dacc526dc695..dfc3f512918f 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > @@ -31,7 +31,6 @@ properties:
> > > >        - description: normal conversion, include EOC (End of Conversion),
> > > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > >            JECH (End of injected Chain).
> > > > -      - description: Self-testing Interrupts.  
> > 
> > Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...  
> 
> Huh, wonder how I missed that. I thought I double checked...
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.

Happens to us all!  Applied patch 1 to the togreg branch of iio.git and pushed
it out as testing so 0-day can poke at it.
Thanks,

Jonathan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
index dacc526dc695..dfc3f512918f 100644
--- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
@@ -31,7 +31,6 @@  properties:
       - description: normal conversion, include EOC (End of Conversion),
           ECH (End of Chain), JEOC (End of Injected Conversion) and
           JECH (End of injected Chain).
-      - description: Self-testing Interrupts.
 
   clocks:
     maxItems: 1
@@ -70,8 +69,7 @@  examples:
             reg = <0x44530000 0x10000>;
             interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
             clocks = <&clk IMX93_CLK_ADC1_GATE>;
             clock-names = "ipg";
             vref-supply = <&reg_vref_1v8>;