| Message ID | 20240227034539.193573-5-aford173@gmail.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | gpu: powervr-rogue: Add PowerVR support for some Renesas devices | expand |
Hi Adam, Thanks for your patch! On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > The GPU on the R-Car H3 is a Rogue GX6650 which uses firmware > rogue_4.46.6.61_v1.fw available from Imagination. s/61/62/ > > When enumerated, it appears as: > powervr fd000000.gpu: [drm] loaded firmware powervr/rogue_4.46.6.62_v1.fw > powervr fd000000.gpu: [drm] FW version v1.0 (build 6513336 OS) Do you have a different build number? On Salvator-XS with R-Car H3 ES2.0: powervr fd000000.gpu: [drm] loaded firmware powervr/rogue_4.46.6.62_v1.fw powervr fd000000.gpu: [drm] FW version v1.0 (build 6538781 OS) [drm] Initialized powervr 1.0.0 20230904 for fd000000.gpu on minor 1 > > Signed-off-by: Adam Ford <aford173@gmail.com> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > @@ -2771,6 +2771,16 @@ gic: interrupt-controller@f1010000 { > resets = <&cpg 408>; > }; > > + gpu: gpu@fd000000 { > + compatible = "renesas,r8a77951-gpu", "img,img-axe"; renesas,r8a7795-gpu > + reg = <0 0xfd000000 0 0x20000>; > + clocks = <&cpg CPG_MOD 112>; > + clock-names = "core"; > + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&sysc R8A7795_PD_3DG_E>; > + resets = <&cpg 112>; > + }; > + > pciec0: pcie@fe000000 { > compatible = "renesas,pcie-r8a7795", > "renesas,pcie-rcar-gen3"; Gr{oetje,eeting}s, Geert
On Tue, Feb 27, 2024 at 2:11 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Adam, > > Thanks for your patch! > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > > The GPU on the R-Car H3 is a Rogue GX6650 which uses firmware > > rogue_4.46.6.61_v1.fw available from Imagination. > > s/61/62/ > > > > > When enumerated, it appears as: > > powervr fd000000.gpu: [drm] loaded firmware powervr/rogue_4.46.6.62_v1.fw > > powervr fd000000.gpu: [drm] FW version v1.0 (build 6513336 OS) > > Do you have a different build number? I don't actually have this board. I just copy-pasted what I thought it was. If you have build number that's more appropriate, I can use that in the future. adam > > On Salvator-XS with R-Car H3 ES2.0: > > powervr fd000000.gpu: [drm] loaded firmware powervr/rogue_4.46.6.62_v1.fw > powervr fd000000.gpu: [drm] FW version v1.0 (build 6538781 OS) > [drm] Initialized powervr 1.0.0 20230904 for fd000000.gpu on minor 1 > > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > > @@ -2771,6 +2771,16 @@ gic: interrupt-controller@f1010000 { > > resets = <&cpg 408>; > > }; > > > > + gpu: gpu@fd000000 { > > + compatible = "renesas,r8a77951-gpu", "img,img-axe"; > > renesas,r8a7795-gpu > > > + reg = <0 0xfd000000 0 0x20000>; > > + clocks = <&cpg CPG_MOD 112>; > > + clock-names = "core"; > > + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; > > + power-domains = <&sysc R8A7795_PD_3DG_E>; > > + resets = <&cpg 112>; > > + }; > > + > > pciec0: pcie@fe000000 { > > compatible = "renesas,pcie-r8a7795", > > "renesas,pcie-rcar-gen3"; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi index bea4edd17d53..3e9defaeb00f 100644 --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi @@ -2771,6 +2771,16 @@ gic: interrupt-controller@f1010000 { resets = <&cpg 408>; }; + gpu: gpu@fd000000 { + compatible = "renesas,r8a77951-gpu", "img,img-axe"; + reg = <0 0xfd000000 0 0x20000>; + clocks = <&cpg CPG_MOD 112>; + clock-names = "core"; + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&sysc R8A7795_PD_3DG_E>; + resets = <&cpg 112>; + }; + pciec0: pcie@fe000000 { compatible = "renesas,pcie-r8a7795", "renesas,pcie-rcar-gen3";
The GPU on the R-Car H3 is a Rogue GX6650 which uses firmware rogue_4.46.6.61_v1.fw available from Imagination. When enumerated, it appears as: powervr fd000000.gpu: [drm] loaded firmware powervr/rogue_4.46.6.62_v1.fw powervr fd000000.gpu: [drm] FW version v1.0 (build 6513336 OS) Signed-off-by: Adam Ford <aford173@gmail.com>