| Message ID | cover.1709034476.git.ukleinek@debian.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: Add basic support for QNAP TS-433 | expand |
Am Dienstag, 27. Februar 2024, 12:52:35 CET schrieb Uwe Kleine-König: > Hello, > > this is an initial dts to support QNAP's TS-433 NAS. It's enough to > start the debian installer with a custom built kernel (original Debian > kernel fails to open a console, didn't debug that yet) and access HD, > eMMC, RTC and network. > > There are still some missing bits and pieces, but to make people aware > there are efforts to support this machine and so prevent duplicate work, > I think it makes sense to add the dts in its current form already. woohoo and yes we're adding support for not 100% supported boards all the time, so adding basic support and extending it later is fully ok. For people thinking about "following along at home", how much voodoo is involved to make the device boot said Debian installer? ;-) Heiko
On Tue, 27 Feb 2024 12:52:35 +0100, Uwe Kleine-König wrote: > Hello, > > this is an initial dts to support QNAP's TS-433 NAS. It's enough to > start the debian installer with a custom built kernel (original Debian > kernel fails to open a console, didn't debug that yet) and access HD, > eMMC, RTC and network. > > There are still some missing bits and pieces, but to make people aware > there are efforts to support this machine and so prevent duplicate work, > I think it makes sense to add the dts in its current form already. > > Best regards > Uwe > > Uwe Kleine-König (2): > dt-bindings: arm: rockchip: Add QNAP TS-433 > arm64: dts: rockchip: Add basic support for QNAP TS-433 > > .../devicetree/bindings/arm/rockchip.yaml | 5 ++ > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3568-qnap-ts433.dts | 86 +++++++++++++++++++ > 3 files changed, 92 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts > > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d > -- > 2.43.0 > > My bot found new DT warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3568-qnap-ts433.dtb' for cover.1709034476.git.ukleinek@debian.org: arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: video-codec@fdea0400: 'interrupt-names' is a required property from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml# arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: i2s@fe420000: reset-names:0: 'm' is not one of ['tx-m', 'rx-m'] from schema $id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml#
Hello Heiko, On Tue, Feb 27, 2024 at 01:26:19PM +0100, Heiko Stübner wrote: > Am Dienstag, 27. Februar 2024, 12:52:35 CET schrieb Uwe Kleine-König: > > this is an initial dts to support QNAP's TS-433 NAS. It's enough to > > start the debian installer with a custom built kernel (original Debian > > kernel fails to open a console, didn't debug that yet) and access HD, > > eMMC, RTC and network. > > > > There are still some missing bits and pieces, but to make people aware > > there are efforts to support this machine and so prevent duplicate work, > > I think it makes sense to add the dts in its current form already. > > woohoo and yes we're adding support for not 100% supported boards > all the time, so adding basic support and extending it later is fully ok. > > For people thinking about "following along at home", how much voodoo > is involved to make the device boot said Debian installer? ;-) I'd ask these people for some patience as I intend to document the details in the Debian wiki. For those who are not that patient, here comes the short version: I compiled v6.8-rc1 with this patch, put the resulting kernel image (Image) and device tree into /srv/tftp, together with the initrd[1] from Debian and then typed in U-boot (using the vendor version): setenv laptop 192.168.144.173 setenv bootargs ${bootargs} clk_ignore_unused ignore_loglevel i2c dev 0; i2c mw 0x20 0xf4 0x10; i2c mw 0x40 0x00 0xa3; run phy_cmd dhcp ${fdt_addr_r} ${laptop}:rk3568-qnap-ts433.dtb dhcp ${kernel_addr_r} ${laptop}:Image dhcp 0x0b100000 ${laptop}:debian/20240222-02:09/initrd.gz booti ${kernel_addr_r} 0x0b100000:$filesize ${fdt_addr_r} Feel free to ping me on irc if you have further questions. Best regards Uwe [1] I used https://d-i.debian.org/daily-images/arm64/20240222-02:09/netboot/debian-installer/arm64/initrd.gz
Hello Rob, On Tue, Feb 27, 2024 at 07:45:06AM -0600, Rob Herring wrote: > New warnings running 'make CHECK_DTBS=y rockchip/rk3568-qnap-ts433.dtb' for cover.1709034476.git.ukleinek@debian.org: > > arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: video-codec@fdea0400: 'interrupt-names' is a required property > from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml# > arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: i2s@fe420000: reset-names:0: 'm' is not one of ['tx-m', 'rx-m'] > from schema $id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml# Yes, I saw these, too. But given that the added dts doesn't touch these two nodes, I thought this to be a problem of rk3568.dtsi that I can ignore for this series. Best regards Uwe
Am Dienstag, 27. Februar 2024, 14:55:57 CET schrieb Uwe Kleine-König: > Hello Rob, > > On Tue, Feb 27, 2024 at 07:45:06AM -0600, Rob Herring wrote: > > New warnings running 'make CHECK_DTBS=y rockchip/rk3568-qnap-ts433.dtb' for cover.1709034476.git.ukleinek@debian.org: > > > > arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: video-codec@fdea0400: 'interrupt-names' is a required property > > from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml# > > arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dtb: i2s@fe420000: reset-names:0: 'm' is not one of ['tx-m', 'rx-m'] > > from schema $id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml# > > Yes, I saw these, too. But given that the added dts doesn't touch these > two nodes, I thought this to be a problem of rk3568.dtsi that I can > ignore for this series. I think I found suitable fixes for those in [0]. The question would be, if the bot finding errors causes the patch to get removed from the review queue, because the binding addition still would profit from an Ack :-) Heiko [0] https://lore.kernel.org/linux-rockchip/20240227173526.710056-1-heiko@sntech.de/
On Tue, 27 Feb 2024 12:52:35 +0100, Uwe Kleine-König wrote: > this is an initial dts to support QNAP's TS-433 NAS. It's enough to > start the debian installer with a custom built kernel (original Debian > kernel fails to open a console, didn't debug that yet) and access HD, > eMMC, RTC and network. > > There are still some missing bits and pieces, but to make people aware > there are efforts to support this machine and so prevent duplicate work, > I think it makes sense to add the dts in its current form already. > > [...] Applied, thanks! [1/2] dt-bindings: arm: rockchip: Add QNAP TS-433 commit: 0660dd951e1a09e155e31732fbdf735112b5d6c4 [2/2] arm64: dts: rockchip: Add basic support for QNAP TS-433 commit: 9da1c0327d58e0cfc2d86799192585ddeb1ae4a0 Moved &gmac above &i2c* - alphabetical sorting and all Best regards,