mbox series

[v2,0/2] Change xwrite() to write_in_full() in builtins.

Message ID 20240227150934.7950-1-randall.becker@nexbridge.ca (mailing list archive)
Headers show
Series Change xwrite() to write_in_full() in builtins. | expand

Message

Randall S. Becker Feb. 27, 2024, 3:09 p.m. UTC
From: "Randall S. Becker" <rsbecker@nexbridge.com>

This series replaces xwrite to write_in_full in builtins/. The change is
required to fix critical problems that prevent full writes to be
processed by on platforms where xwrite may be limited to a platform size
limit. Further changes outside of builtins/ may be required but do not
appear to be as urgent as this change, which causes test breakage in
t7704. A separate series will be contributed for changes outside of
builtins/ at a later date.

The change in unpack-objects.c is necessary as len is being passed into
xwrite that exceeds the size supported by the limit in that method
(56Kb on NonStop ia64). 

Randall S. Becker (3):
  builtin/repack.c: change xwrite to write_in_full and report errors.
  builtin/receive-pack.c: change xwrite to write_in_full.
  builtin/unpack-objects.c: change xwrite to write_in_full avoid
    truncation.

 builtin/receive-pack.c   | 2 +-
 builtin/repack.c         | 9 +++++++--
 builtin/unpack-objects.c | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)

Comments

Randall S. Becker Feb. 27, 2024, 9:11 p.m. UTC | #1
Please withdraw this series.

>-----Original Message-----
>From: Randall S. Becker <the.n.e.key@gmail.com>
>Sent: Tuesday, February 27, 2024 10:10 AM
>To: git@vger.kernel.org
>Cc: Randall S. Becker <rsbecker@nexbridge.com>
>Subject: [PATCH v2 0/2] Change xwrite() to write_in_full() in builtins.
>
>From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
>This series replaces xwrite to write_in_full in builtins/. The change is
required to fix critical problems that prevent full writes to be
>processed by on platforms where xwrite may be limited to a platform size
limit. Further changes outside of builtins/ may be required
>but do not appear to be as urgent as this change, which causes test
breakage in t7704. A separate series will be contributed for
>changes outside of builtins/ at a later date.
>
>The change in unpack-objects.c is necessary as len is being passed into
xwrite that exceeds the size supported by the limit in that
>method (56Kb on NonStop ia64).
>
>Randall S. Becker (3):
>  builtin/repack.c: change xwrite to write_in_full and report errors.
>  builtin/receive-pack.c: change xwrite to write_in_full.
>  builtin/unpack-objects.c: change xwrite to write_in_full avoid
>    truncation.
>
> builtin/receive-pack.c   | 2 +-
> builtin/repack.c         | 9 +++++++--
> builtin/unpack-objects.c | 2 +-
> 3 files changed, 9 insertions(+), 4 deletions(-)
>
>--
>2.42.1