| Message ID | 20240227-asrc_8qxp-v2-2-521bcc7eb1c0@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: imx8qxp add asrc and sai | expand |
On Tue, 27 Feb 2024 15:54:10 -0500, Frank Li wrote: > fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms > have 1 interrupt. > > Increase max interrupt number to 2 and add restriction for platforms except > i.MX8QXP and i.MX8QM. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/sound/fsl,spdif.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/fsl,spdif.example.dtb: spdif@2004000: interrupts: [[0, 52, 4]] is too short from schema $id: http://devicetree.org/schemas/sound/fsl,spdif.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240227-asrc_8qxp-v2-2-521bcc7eb1c0@nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml index 82430f1d5e5a2..debf0da759924 100644 --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml @@ -31,7 +31,7 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + maxItems: 2 dmas: items: @@ -100,6 +100,23 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + enum: + - fsl,imx35-spdif + - fsl,vf610-spdif + - fsl,imx6sx-spdif + - fsl,imx8mq-spdif + - fsl,imx8mm-spdif + - fsl,imx8mn-spdif + - fsl,imx8ulp-spdif + then: + properties: + interrupts: + maxItems: 1 + examples: - | spdif@2004000 {
fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms have 1 interrupt. Increase max interrupt number to 2 and add restriction for platforms except i.MX8QXP and i.MX8QM. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../devicetree/bindings/sound/fsl,spdif.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)