| Message ID | 20240228-topic-sm8x50-upstream-phy-combo-fix-duplicate-return-v1-1-60027a37cab1@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | phy: qcom: qmp-combo: fix duplicate return in qmp_v4_configure_dp_phy | expand |
On 2/28/24 18:05, Neil Armstrong wrote: > Remove duplicate "return 0" in qmp_v4_configure_dp_phy() > > Fixes: 186ad90aa49f ("phy: qcom: qmp-combo: reuse register layouts for even more registers") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Somebody was just trying to go up 2 levels up! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 2/28/2024 9:05 AM, Neil Armstrong wrote: > Remove duplicate "return 0" in qmp_v4_configure_dp_phy() > > Fixes: 186ad90aa49f ("phy: qcom: qmp-combo: reuse register layouts for even more registers") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Wed, 28 Feb 2024 18:05:13 +0100, Neil Armstrong wrote: > Remove duplicate "return 0" in qmp_v4_configure_dp_phy() > > Applied, thanks! [1/1] phy: qcom: qmp-combo: fix duplicate return in qmp_v4_configure_dp_phy commit: e298ae7caafcc429e0fc4b3779f1738c0acc5dac Best regards,
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index 546d3c6bee32..2f341613fd31 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2431,8 +2431,6 @@ static int qmp_v4_configure_dp_phy(struct qmp_combo *qmp) writel(0x20, qmp->dp_tx2 + cfg->regs[QPHY_TX_TX_EMP_POST1_LVL]); return 0; - - return 0; } /*
Remove duplicate "return 0" in qmp_v4_configure_dp_phy() Fixes: 186ad90aa49f ("phy: qcom: qmp-combo: reuse register layouts for even more registers") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 -- 1 file changed, 2 deletions(-) --- base-commit: 20af1ca418d2c0b11bc2a1fe8c0c88f67bcc2a7e change-id: 20240228-topic-sm8x50-upstream-phy-combo-fix-duplicate-return-6b5135756006 Best regards,