| Message ID | 20240228-tidss-dev-err-probe-v1-1-5482252326d3@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port | expand |
Andrew Halaney <ahalaney@redhat.com> writes: Hello Andrew, > This gets logged out to /sys/kernel/debug/devices_deferred in the > -EPROBE_DEFER case and as an error otherwise. The message here provides > useful information to the user when troubleshooting why their display is > not working in either case, so let's make it output appropriately. > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > There's definitely more spots in this driver that could be upgraded from > dev_dbg() to something more appropriate, but this one burned me today so > I thought I'd send a patch for it specifically before I forget. > --- Makes sense to me and I agree that's useful to have that information there. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hello Andrew, Many thanks for proposing this. On Wed, Feb 28, 2024 at 11:02 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > > Andrew Halaney <ahalaney@redhat.com> writes: > > Hello Andrew, > > > This gets logged out to /sys/kernel/debug/devices_deferred in the > > -EPROBE_DEFER case and as an error otherwise. The message here provides > > useful information to the user when troubleshooting why their display is > > not working in either case, so let's make it output appropriately. > > > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > > --- > > There's definitely more spots in this driver that could be upgraded from > > dev_dbg() to something more appropriate, but this one burned me today so > > I thought I'd send a patch for it specifically before I forget. > > --- > > Makes sense to me and I agree that's useful to have that information there. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > Logging in /sys/kernel/debug/devices_deferred was useful for me, so Tested-by: Enric Balletbo i Serra <eballetbo@kernel.org> Cheers, Enric > -- > Best regards, > > Javier Martinez Canillas > Core Platforms > Red Hat >
On Wed, 28 Feb 2024 14:12:06 -0600, Andrew Halaney wrote: > This gets logged out to /sys/kernel/debug/devices_deferred in the > -EPROBE_DEFER case and as an error otherwise. The message here provides > useful information to the user when troubleshooting why their display is > not working in either case, so let's make it output appropriately. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index a0e494c806a96..f371518f86971 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -135,8 +135,7 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss) dev_dbg(dev, "no panel/bridge for port %d\n", i); continue; } else if (ret) { - dev_dbg(dev, "port %d probe returned %d\n", i, ret); - return ret; + return dev_err_probe(dev, ret, "port %d probe failed\n", i); } if (panel) {
This gets logged out to /sys/kernel/debug/devices_deferred in the -EPROBE_DEFER case and as an error otherwise. The message here provides useful information to the user when troubleshooting why their display is not working in either case, so let's make it output appropriately. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- There's definitely more spots in this driver that could be upgraded from dev_dbg() to something more appropriate, but this one burned me today so I thought I'd send a patch for it specifically before I forget. --- drivers/gpu/drm/tidss/tidss_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- base-commit: 22ba90670a51a18c6b36d285fddf92b9887c0bc3 change-id: 20240228-tidss-dev-err-probe-fa61fb057029 Best regards,