| Message ID | 20240228094010.2254245-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency | expand |
On Wed, 28 Feb 2024, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The dependency is required to avoid a link failure after support for > battery hooks was added: > > ld.lld: error: undefined symbol: battery_hook_unregister > >>> referenced by fujitsu-laptop.c > >>> drivers/platform/x86/fujitsu-laptop.o:(acpi_fujitsu_laptop_remove) in archive vmlinux.a > > Fixes: 611d56d76dee ("platform/x86/fujitsu-laptop: Add battery charge control support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 6dbd40e2aeda..d9851b79bfe5 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -371,6 +371,7 @@ config FUJITSU_LAPTOP > depends on INPUT > depends on BACKLIGHT_CLASS_DEVICE > depends on ACPI_VIDEO || ACPI_VIDEO = n > + depends on ACPI_BATTERY > select INPUT_SPARSEKMAP > select NEW_LEDS > select LEDS_CLASS Thanks. We already fixed this in the originating commit (and now the fixed version of the commit has also propaged to the for-next branch).
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 6dbd40e2aeda..d9851b79bfe5 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -371,6 +371,7 @@ config FUJITSU_LAPTOP depends on INPUT depends on BACKLIGHT_CLASS_DEVICE depends on ACPI_VIDEO || ACPI_VIDEO = n + depends on ACPI_BATTERY select INPUT_SPARSEKMAP select NEW_LEDS select LEDS_CLASS